From: Andrew Morton <akpm@osdl.org>
To: "Noah J. Misch" <noah@caltech.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Missing include in swap.h for some architectures
Date: Mon, 20 Oct 2003 02:25:36 -0700 [thread overview]
Message-ID: <20031020022536.796531c4.akpm@osdl.org> (raw)
In-Reply-To: <Pine.GSO.4.58.0310171453450.13905@blinky>
"Noah J. Misch" <noah@caltech.edu> wrote:
>
> # The linux/swap.h header uses the page_cache_release and release_pages
> # functions declared in linux/pagemap.h when CONFIG_SWAP is disabled. Add
> # an include of linux/pagemap.h so swap.h finds those declarations on
> # architectures that don't include pagemap.h indirectly.
This carries a small risk of breaking things. I think I'd prefer that the
offending .c files just include pagemap.h please.
next prev parent reply other threads:[~2003-10-20 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-20 5:17 Noah J. Misch
2003-10-20 9:25 ` Andrew Morton [this message]
2003-10-21 13:47 ` Noah J. Misch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031020022536.796531c4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noah@caltech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®