From: "Noah J. Misch" <noah@caltech.edu>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Missing include in swap.h for some architectures
Date: Sun, 19 Oct 2003 22:17:42 -0700 (PDT) [thread overview]
Message-ID: <Pine.GSO.4.58.0310171453450.13905@blinky> (raw)
Greetings All,
This flaw broke kernel builds configured with SWAP=n on some architectures,
particularly alpha and ia64. Since i386 managed to include pagemap.h
indirectly, this did not crop up there. See log for details.
This applies to linux-2.5 BK as of 0400 UTC 10/20/2003 and passes all kinds of
ridiculous compile tests, probably including (allyesconfig - broken stuff) on
sparc, sparc64, ia64, alpha, and i386. Don't know about VAX...
One could place this include within the #ifdef'ed block that contains the
relevant function uses, but that's not generally within the style of this file
or most others, per my recollection.
I didn't know who takes things like this, so if anyone would like to pick this
up, please do so. Otherwise, I will send it to Linus after a few days.
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1367 -> 1.1368
# include/linux/swap.h 1.79 -> 1.80
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/10/16 noah@caltech.edu 1.1368
# The linux/swap.h header uses the page_cache_release and release_pages
# functions declared in linux/pagemap.h when CONFIG_SWAP is disabled. Add
# an include of linux/pagemap.h so swap.h finds those declarations on
# architectures that don't include pagemap.h indirectly.
# --------------------------------------------
#
diff -Nru a/include/linux/swap.h b/include/linux/swap.h
--- a/include/linux/swap.h Fri Oct 17 13:40:06 2003
+++ b/include/linux/swap.h Fri Oct 17 13:40:06 2003
@@ -4,6 +4,7 @@
#include <linux/config.h>
#include <linux/spinlock.h>
#include <linux/linkage.h>
+#include <linux/pagemap.h>
#include <linux/mmzone.h>
#include <linux/list.h>
#include <linux/sched.h>
next reply other threads:[~2003-10-20 5:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-20 5:17 Noah J. Misch [this message]
2003-10-20 9:25 ` Andrew Morton
2003-10-21 13:47 ` Noah J. Misch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.58.0310171453450.13905@blinky \
--to=noah@caltech.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®