From: Tomas Szepe <szepe@pinerecords.com>
To: Larry McVoy <lm@work.bitmover.com>,
Chad Kitching <CKitching@powerlandcomputers.com>,
linux-kernel@vger.kernel.org
Subject: Re: BK2CVS problem
Date: Thu, 6 Nov 2003 01:52:24 +0100 [thread overview]
Message-ID: <20031106005224.GA7105@louise.pinerecords.com> (raw)
In-Reply-To: <20031105230350.GB12992@work.bitmover.com>
On Nov-05 2003, Wed, 15:03 -0800
Larry McVoy <lm@bitmover.com> wrote:
> > > > + if ((options == (__WCLONE|__WALL)) && (current->uid = 0))
> > > > + retval = -EINVAL;
> > >
> > > That looks odd
> >
> > Setting current->uid to zero when options __WCLONE and __WALL are set? The
> > retval is dead code because of the next line, but it looks like an attempt
> > to backdoor the kernel, does it not?
>
> It sure does. Note "current->uid = 0", not "current->uid == 0".
> Good eyes, I missed that. This function is sys_wait4() so by passing in
> __WCLONE|__WALL you are root. How nice.
Also note the extra parentheses to avoid a gcc warning.
--
Tomas Szepe <szepe@pinerecords.com>
next prev parent reply other threads:[~2003-11-06 0:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-05 22:48 Chad Kitching
2003-11-05 22:53 ` Zwane Mwaikambo
2003-11-05 23:03 ` Larry McVoy
2003-11-06 0:52 ` Tomas Szepe [this message]
2003-11-06 1:57 ` Andreas Dilger
2003-11-06 2:20 ` Linus Torvalds
2003-11-06 3:01 ` Larry McVoy
2003-11-06 10:40 ` Matthias Andree
2003-11-06 4:09 ` Scott Robert Ladd
2003-11-06 10:06 ` bert hubert
2003-11-06 13:22 ` Theodore Ts'o
2003-11-06 14:43 ` Rik van Riel
2003-11-06 15:56 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2003-11-05 20:45 Larry McVoy
2003-11-05 20:58 ` Matthew Dharm
2003-11-05 22:23 ` Larry McVoy
2003-11-05 22:33 ` Zwane Mwaikambo
2003-11-05 22:51 ` Andries Brouwer
2003-11-06 7:07 ` Brian McGroarty
2003-11-06 11:41 ` Andrew Walrond
2003-11-06 12:02 ` nosp
2003-11-06 12:02 ` Xavier Bestel
2003-11-06 13:27 ` Scott Robert Ladd
2003-11-06 13:59 ` Richard B. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031106005224.GA7105@louise.pinerecords.com \
--to=szepe@pinerecords.com \
--cc=CKitching@powerlandcomputers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm@work.bitmover.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome