From: IWAMOTO Toshihiro <iwamoto@valinux.co.jp>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.0-test10 O_DIRECT memory leak fix
Date: Mon, 01 Dec 2003 16:02:01 +0900 [thread overview]
Message-ID: <20031201070201.A4D667007A@sv1.valinux.co.jp> (raw)
In-Reply-To: <200311251449.50397.pbadari@us.ibm.com>
At Tue, 25 Nov 2003 14:49:50 -0800,
Badari Pulavarty wrote:
>
> [1 <text/plain; us-ascii (quoted-printable)>]
> Hi Andrew,
>
> I found the problem with O_DIRECT memory leak.
>
> The problem is, when we are doing DIO read and crossed the end of file -
> we don't release referencess on all the pages we got from get_user_pages().
> (since it is a sucess case).
>
> The fix is to call dio_cleanup() even for sucess cases. Can you please
> review this ? I tested the patch with fsstress and there are no memory leak
> problems now.
>
> Thanks,
> Badari
> [2 dioleak.patch <text/x-diff; us-ascii (7bit)>]
I've tested this patch with linux-2.6.0-test11 (plus my memory
hotplug patch) on the machine I observed the memory leak.
The leak seems to be fixed. Thanks.
--
IWAMOTO Toshihiro
prev parent reply other threads:[~2003-12-01 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-25 22:49 Badari Pulavarty
2003-11-26 1:05 ` Andrew Morton
2003-12-01 7:02 ` IWAMOTO Toshihiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031201070201.A4D667007A@sv1.valinux.co.jp \
--to=iwamoto@valinux.co.jp \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®