mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
	macro@ds2.pg.gda.pl, Ralf Baechle <ralf@linux-mips.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 070] NCR53C9x unused SCp.have_data_in
Date: Sun, 7 Dec 2003 21:49:26 +0100	[thread overview]
Message-ID: <200312072049.hB7KnQ43000653@callisto.of.borg> (raw)

NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W.
Rozycki). This affects the following drivers:
  - Amiga Oktagon SCSI
  - DECstation SCSI

The change for DECstation SCSI sneaked in through a MIPS update.

--- linux-2.4.23/drivers/scsi/NCR53C9x.c	Sat Aug 17 14:10:41 2002
+++ linux-m68k-2.4.23/drivers/scsi/NCR53C9x.c	Wed Jan 22 12:07:13 2003
@@ -917,7 +917,7 @@
 		if (esp->dma_mmu_get_scsi_one)
 			esp->dma_mmu_get_scsi_one(esp, sp);
 		else
-			sp->SCp.have_data_in = (int) sp->SCp.ptr =
+			sp->SCp.ptr =
 				(char *) virt_to_phys(sp->request_buffer);
 	} else {
 		sp->SCp.buffer = (struct scatterlist *) sp->buffer;
--- linux-2.4.23/drivers/scsi/oktagon_esp.c	Mon Apr  1 13:02:02 2002
+++ linux-m68k-2.4.23/drivers/scsi/oktagon_esp.c	Wed Jan 22 12:07:17 2003
@@ -548,7 +548,7 @@
 
 void dma_mmu_get_scsi_one(struct NCR_ESP *esp, Scsi_Cmnd *sp)
 {
-        sp->SCp.have_data_in = (int) sp->SCp.ptr =
+        sp->SCp.ptr =
                 sp->request_buffer;
 }
 

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

             reply	other threads:[~2003-12-07 20:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-07 20:49 Geert Uytterhoeven [this message]
2004-03-22 10:00 Geert Uytterhoeven
2004-03-23 15:13 ` Marcelo Tosatti
2004-03-23 15:35   ` Geert Uytterhoeven
2004-03-23 17:18     ` Marcelo Tosatti
2004-04-23 15:10 Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200312072049.hB7KnQ43000653@callisto.of.borg \
    --to=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@ds2.pg.gda.pl \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®