From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
"Maciej W. Rozycki" <macro@ds2.pg.gda.pl>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 070] NCR53C9x unused SCp.have_data_in
Date: Tue, 23 Mar 2004 14:18:52 -0300 (BRT) [thread overview]
Message-ID: <Pine.LNX.4.58L.0403231415310.2896@logos.cnet> (raw)
In-Reply-To: <Pine.GSO.4.58.0403231634241.8977@waterleaf.sonytel.be>
On Tue, 23 Mar 2004, Geert Uytterhoeven wrote:
> On Tue, 23 Mar 2004, Marcelo Tosatti wrote:
> > On Mon, 22 Mar 2004, Geert Uytterhoeven wrote:
> > > NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W.
> > > Rozycki). This affects the following drivers:
> > > - Amiga Oktagon SCSI
> > > - DECstation SCSI
> > >
> > > The change for DECstation SCSI sneaked in through a MIPS update.
> > >
> > > --- linux-2.4.26-pre5/drivers/scsi/NCR53C9x.c Sat Aug 17 14:10:41 2002
> > > +++ linux-m68k-2.4.26-pre5/drivers/scsi/NCR53C9x.c Wed Jan 22 12:07:13 2003
> > > @@ -917,7 +917,7 @@
> > > if (esp->dma_mmu_get_scsi_one)
> > > esp->dma_mmu_get_scsi_one(esp, sp);
> > > else
> > > - sp->SCp.have_data_in = (int) sp->SCp.ptr =
> > > + sp->SCp.ptr =
> > > (char *) virt_to_phys(sp->request_buffer);
> > > } else {
> > > sp->SCp.buffer = (struct scatterlist *) sp->buffer;
> > > --- linux-2.4.26-pre5/drivers/scsi/oktagon_esp.c Mon Apr 1 13:02:02 2002
> > > +++ linux-m68k-2.4.26-pre5/drivers/scsi/oktagon_esp.c Wed Jan 22 12:07:17 2003
> > > @@ -548,7 +548,7 @@
> > >
> > > void dma_mmu_get_scsi_one(struct NCR_ESP *esp, Scsi_Cmnd *sp)
> > > {
> > > - sp->SCp.have_data_in = (int) sp->SCp.ptr =
> > > + sp->SCp.ptr =
> > > sp->request_buffer;
> > > }
> >
> > Can't we live with this?
>
> Yes.
>
> > Is removing it fixing any problem?
>
> No, it's just a cleanup.
>
> > Yes, I'm being picky.
>
> In that case, you can drop it.
>
> (BTW, picky for 2.4.26-rc*, or for 2.4 in general?)
Picky in general for 2.4. In this case specifically I feel the cleanup
can possibly, "remotely" cause some issues. Better to be off.
next prev parent reply other threads:[~2004-03-23 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-22 10:00 Geert Uytterhoeven
2004-03-23 15:13 ` Marcelo Tosatti
2004-03-23 15:35 ` Geert Uytterhoeven
2004-03-23 17:18 ` Marcelo Tosatti [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-04-23 15:10 Geert Uytterhoeven
2003-12-07 20:49 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58L.0403231415310.2896@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®