From: Andrew Morton <akpm@osdl.org>
To: corbet@lwn.net (Jonathan Corbet)
Cc: anton@samba.org, mh@nadir.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] seq_file version of /proc/interrupts
Date: Mon, 22 Dec 2003 16:49:46 -0800 [thread overview]
Message-ID: <20031222164946.61644783.akpm@osdl.org> (raw)
In-Reply-To: <20031223003831.25486.qmail@lwn.net>
corbet@lwn.net (Jonathan Corbet) wrote:
>
> > - int i, j;
> > + int i = *(int *) v, j;
>
> > That int * has to be a loff_t * or bad things will happen on a 64bit big
> > endian platform :)
>
> You mean the world's not all an x86? What are things coming to?
>
> Andrew, Marc, this seems almost certain to the the source of the problem
> you brought to my attention. I'll try to get a supplemental patch to you
> tomorrow. Obviously, it should be a loff_t for all architectures, even if
> it works for most now.
hmm, I seem to have already fixed pppc64. I'll fix up the other
architectures.
next prev parent reply other threads:[~2003-12-23 0:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-13 17:36 Jonathan Corbet
2003-11-13 18:02 ` Jesse Barnes
2003-11-13 19:35 ` viro
2003-11-13 21:39 ` Jonathan Corbet
2003-11-13 22:26 ` Erik Jacobson
2003-11-20 16:58 ` Erik Jacobson
2003-12-23 0:22 ` Anton Blanchard
2003-12-23 0:38 ` Jonathan Corbet
2003-12-23 0:49 ` Andrew Morton [this message]
2003-12-23 1:18 ` Mike Fedyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031222164946.61644783.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=anton@samba.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mh@nadir.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome