From: viro@parcelfarce.linux.theplanet.co.uk
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Matt Mackall <mpm@selenic.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.1-rc1-tiny1 tree for small systems
Date: Mon, 5 Jan 2004 00:34:26 +0000 [thread overview]
Message-ID: <20040105003426.GZ4176@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <m1ekufgt72.fsf@ebiederm.dsl.xmission.com>
On Sun, Jan 04, 2004 at 05:00:49PM -0700, Eric W. Biederman wrote:
1) make block-based filesystems dependent on CONFIG_BLOCK
> --- linux-2.6.1-rc1-tiny1.eb1/fs/super.c Wed Dec 17 19:58:48 2003
> +++ linux-2.6.1-rc1-tiny1.eb2/fs/super.c Sun Jan 4 15:18:28 2004
> @@ -473,8 +473,10 @@
> {
> int retval;
>
> +#ifdef CONFIG_BLOCK_DEVICES
> if (!(flags & MS_RDONLY) && bdev_read_only(sb->s_bdev))
> return -EACCES;
> +#endif
> if (flags & MS_RDONLY)
> acct_auto_close(sb);
> shrink_dcache_sb(sb);
> @@ -588,6 +590,7 @@
> return (void *)s->s_bdev == data;
> }
Tons of stuff here make sense only for block-based filesystems (e.g. the
function immediately above ;-). Ifdef, or, better yet, move to fs/block_dev.c
> +cond_syscall(sys_fsync)
> +cond_syscall(sys_fdatasync)
Huh? They should work for network filesystems.
next prev parent reply other threads:[~2004-01-05 0:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-03 3:08 Matt Mackall
2004-01-04 7:42 ` Eric W. Biederman
2004-01-04 8:40 ` Matt Mackall
2004-01-04 16:02 ` Eric W. Biederman
2004-01-05 0:00 ` Eric W. Biederman
2004-01-05 0:34 ` viro [this message]
2004-01-05 4:34 ` Eric W. Biederman
[not found] ` <20040105170938.GY18208@waste.org>
2004-01-08 19:22 ` Eric W. Biederman
2004-01-09 20:15 ` Arnaldo Carvalho de Melo
2004-01-10 21:49 ` Matt Mackall
2004-01-08 21:04 ` bill davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040105003426.GZ4176@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®