Re: Fw: Re: 2.6.1-mm1 - OOPs and hangs during modprobe

Re: Fw: Re: 2.6.1-mm1 - OOPs and hangs during modprobe

[Rusty Russell]

In message <20040109145659.5e18419b.akpm@osdl.org> you write:
> dude,

Oops, you have an older version.

How did that happen... oh, because I sent it to you.  Fuck.

But either way, it shouldn't be triggering.  Andrew, please revert it,
and I'll work with Vladis to figure out what's happening.

Vladis, relative patch, actually sets error code.  What happens now?

Please send module which fails if it still fails...

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.1-rc2-bk2/kernel/module.c working-2.6.1-rc2-bk2-truncated_module/kernel/module.c
--- linux-2.6.1-rc2-bk2/kernel/module.c	2003-11-24 15:42:33.000000000 +1100
+++ working-2.6.1-rc2-bk2-truncated_module/kernel/module.c	2004-01-08 16:19:01.000000000 +1100
@@ -1682,5 +1688,6 @@ static struct module *load_module(void _
 
  truncated:
 	printk(KERN_ERR "Module len %lu truncated\n", len);
+	err = -ENOEXEC;
 	goto free_hdr;
 }

Re: Fw: Re: 2.6.1-mm1 - OOPs and hangs during modprobe

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

On Sat, 10 Jan 2004 14:11:17 +1100, Rusty Russell said:

> Vladis, relative patch, actually sets error code.  What happens now?

I still get this in the dmesg (2 modules won't load - most of rest are fine)

Module len 6897 truncated
Module len 19014 truncated

However, at least now modprobe manages not to hose up the entire modules stuff, but
simply exits with this error:

FATAL: Error inserting aes (/lib/modules/2.6.1-mm1/kernel/crypto/aes.ko): Invali
d module format

and lsmod and 'cat /proc/modules' don't get borked up afterwards.

> Please send module which fails if it still fails...

Sent under separate cover, the list probably doesn't want the 2 .ko files.. ;)

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]