[2.6][smbfs] smb_open & smb_readpage_sync errors in kernel log

[2.6][smbfs] smb_open & smb_readpage_sync errors in kernel log

[Mike Fedyk]

I've been getting these error messages in my kernel forever, I think even
with 2.2 kernels, and it's still there in 2.6:

smb_open: config/SAM open failed, result=-26
smb_readpage_sync: config/SAM open failed, error=-26

It does this for several locked system files on the windows machines.

This happens during a find command run on the mounted share from one of my
scripts that compares file dates.

Can these printk calls be removed?

Re: [2.6][smbfs] smb_open & smb_readpage_sync errors in kernel log

[Andrew Morton]

Mike Fedyk <mfedyk@matchmail.com> wrote:
>
> I've been getting these error messages in my kernel forever, I think even
> with 2.2 kernels, and it's still there in 2.6:
> 
> smb_open: config/SAM open failed, result=-26
> smb_readpage_sync: config/SAM open failed, error=-26
> 
> It does this for several locked system files on the windows machines.
> 
> This happens during a find command run on the mounted share from one of my
> scripts that compares file dates.
> 
> Can these printk calls be removed?

I think so.  We don't want to allow unprivileged users to spam the
logfiles.


 fs/smbfs/file.c |    5 +----
 fs/smbfs/proc.c |    5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

diff -puN fs/smbfs/proc.c~smbfs-fix-noisiness fs/smbfs/proc.c
--- 25/fs/smbfs/proc.c~smbfs-fix-noisiness	2004-01-19 20:18:16.000000000 -0800
+++ 25-akpm/fs/smbfs/proc.c	2004-01-19 20:18:16.000000000 -0800
@@ -1181,11 +1181,8 @@ smb_open(struct dentry *dentry, int wish
 		result = 0;
 		if (!smb_is_open(inode))
 			result = smb_proc_open(server, dentry, wish);
-		if (result) {
-			PARANOIA("%s/%s open failed, result=%d\n",
-				 DENTRY_PATH(dentry), result);
+		if (result)
 			goto out;
-		}
 		/*
 		 * A successful open means the path is still valid ...
 		 */
diff -puN fs/smbfs/file.c~smbfs-fix-noisiness fs/smbfs/file.c
--- 25/fs/smbfs/file.c~smbfs-fix-noisiness	2004-01-19 20:22:21.000000000 -0800
+++ 25-akpm/fs/smbfs/file.c	2004-01-19 20:22:23.000000000 -0800
@@ -64,11 +64,8 @@ smb_readpage_sync(struct dentry *dentry,
 		DENTRY_PATH(dentry), count, offset, rsize);
 
 	result = smb_open(dentry, SMB_O_RDONLY);
-	if (result < 0) {
-		PARANOIA("%s/%s open failed, error=%d\n",
-			 DENTRY_PATH(dentry), result);
+	if (result < 0)
 		goto io_error;
-	}
 
 	do {
 		if (count < rsize)

_

Re: [2.6][smbfs] smb_open & smb_readpage_sync errors in kernel log

[Mike Fedyk]

On Mon, Jan 19, 2004 at 08:22:43PM -0800, Andrew Morton wrote:
> Mike Fedyk <mfedyk@matchmail.com> wrote:
> >
> > I've been getting these error messages in my kernel forever, I think even
> > with 2.2 kernels, and it's still there in 2.6:
> > 
> > smb_open: config/SAM open failed, result=-26
> > smb_readpage_sync: config/SAM open failed, error=-26
> > 
> > It does this for several locked system files on the windows machines.
> > 
> > This happens during a find command run on the mounted share from one of my
> > scripts that compares file dates.
> > 
> > Can these printk calls be removed?
> 
> I think so.  We don't want to allow unprivileged users to spam the
> logfiles.

Great!

Thanks Andrew.