From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-dvb-maintainer@linuxtv.org, torvalds@osdl.org,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DVB compile fix
Date: Mon, 2 Feb 2004 09:08:55 -0800 [thread overview]
Message-ID: <20040202090855.0b90b2ae.rddunlap@osdl.org> (raw)
In-Reply-To: <Pine.GSO.4.58.0402021709560.19699@waterleaf.sonytel.be>
On Mon, 2 Feb 2004 17:10:40 +0100 (MET) Geert Uytterhoeven <geert@linux-m68k.org> wrote:
|
| Never include <asm/delay.h> directly
|
| --- linux-2.6.2-rc3/drivers/media/dvb/frontends/dst.c 2004-01-06 15:29:13.000000000 +0100
| +++ linux-m68k-2.6.2-rc3/drivers/media/dvb/frontends/dst.c 2004-01-10 17:10:35.000000000 +0100
| @@ -28,8 +28,8 @@
| #include <linux/string.h>
| #include <linux/slab.h>
| #include <linux/vmalloc.h>
| +#include <linux/delay.h>
| #include <asm/div64.h>
| -#include <asm/delay.h>
You could modify <asm/delay.h> the way that
include/asm-i386/rwsem.h is done so that this won't continue
to happen:
#ifndef _LINUX_RWSEM_H
#error "please don't include asm/rwsem.h directly, use linux/rwsem.h instead"
#endif
--
~Randy
kernel-janitors project: http://janitor.kernelnewbies.org/
prev parent reply other threads:[~2004-02-02 17:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-02 16:10 Geert Uytterhoeven
2004-02-02 17:08 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040202090855.0b90b2ae.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=geert@linux-m68k.org \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®