* [PATCH] DVB compile fix
@ 2004-02-02 16:10 Geert Uytterhoeven
2004-02-02 17:08 ` Randy.Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2004-02-02 16:10 UTC (permalink / raw)
To: linux-dvb-maintainer, Linus Torvalds, Andrew Morton
Cc: Linux Kernel Development
Never include <asm/delay.h> directly
--- linux-2.6.2-rc3/drivers/media/dvb/frontends/dst.c 2004-01-06 15:29:13.000000000 +0100
+++ linux-m68k-2.6.2-rc3/drivers/media/dvb/frontends/dst.c 2004-01-10 17:10:35.000000000 +0100
@@ -28,8 +28,8 @@
#include <linux/string.h>
#include <linux/slab.h>
#include <linux/vmalloc.h>
+#include <linux/delay.h>
#include <asm/div64.h>
-#include <asm/delay.h>
#include "dvb_frontend.h"
#include "dvb_functions.h"
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] DVB compile fix
2004-02-02 16:10 [PATCH] DVB compile fix Geert Uytterhoeven
@ 2004-02-02 17:08 ` Randy.Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy.Dunlap @ 2004-02-02 17:08 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-dvb-maintainer, torvalds, akpm, linux-kernel
On Mon, 2 Feb 2004 17:10:40 +0100 (MET) Geert Uytterhoeven <geert@linux-m68k.org> wrote:
|
| Never include <asm/delay.h> directly
|
| --- linux-2.6.2-rc3/drivers/media/dvb/frontends/dst.c 2004-01-06 15:29:13.000000000 +0100
| +++ linux-m68k-2.6.2-rc3/drivers/media/dvb/frontends/dst.c 2004-01-10 17:10:35.000000000 +0100
| @@ -28,8 +28,8 @@
| #include <linux/string.h>
| #include <linux/slab.h>
| #include <linux/vmalloc.h>
| +#include <linux/delay.h>
| #include <asm/div64.h>
| -#include <asm/delay.h>
You could modify <asm/delay.h> the way that
include/asm-i386/rwsem.h is done so that this won't continue
to happen:
#ifndef _LINUX_RWSEM_H
#error "please don't include asm/rwsem.h directly, use linux/rwsem.h instead"
#endif
--
~Randy
kernel-janitors project: http://janitor.kernelnewbies.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-02-02 17:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-02 16:10 [PATCH] DVB compile fix Geert Uytterhoeven
2004-02-02 17:08 ` Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®