mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Critical problem in 2.6.2 and up
@ 2004-02-11  2:58 Marcos D. Marado Torres
  2004-02-11  3:19 ` Andrew Morton
  0 siblings, 1 reply; 6+ messages in thread
From: Marcos D. Marado Torres @ 2004-02-11  2:58 UTC (permalink / raw)
  To: linux-kernel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Greetings,

Somewhere between 2.6.2-rc3 and 2.6.2, more specificly between 2.6.2-rc3 and
2.6.2-rc3-mm1 appeared a patch in the bitkeeper, that was included in
linux.patch used in 2.6.2-rc3-mm1, in 2.6.2 and it's still present.

The patch follows:

diff -Nru a/drivers/block/genhd.c b/drivers/block/genhd.c
- --- a/drivers/block/genhd.c     Wed Feb  4 16:51:35 2004
+++ b/drivers/block/genhd.c     Wed Feb  4 16:51:35 2004
@@ -260,8 +260,10 @@
        if (&sgp->kobj.entry == block_subsys.kset.list.next)
                seq_puts(part, "major minor  #blocks  name\n\n");

- -       /* Don't show non-partitionable devices or empty devices */
- -       if (!get_capacity(sgp) || sgp->minors == 1)
+       /* Don't show non-partitionable removeable devices or empty devices */
+       if (!get_capacity(sgp) ||
+           (sgp->minors == 1 && (sgp->flags & GENHD_FL_REMOVABLE))
+               )
                return 0;

        /* show the full disk and all non-0 size partitions of it */


This patch should be -R's ASAP, since it cause major problems: as an example, I
have an Asus M3700N laptopwhere this patch causes the system to do this:


# lilo

Warning: '/proc/partitions' does not match '/dev' directory structure.
    Name change: '/dev/nbd0' -> '/tmp/dev.0'
Warning: '/dev' directory structure is incomplete; device (43, 0) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 1) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 2) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 3) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 4) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 5) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 6) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 7) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 8) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 9) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 10) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 11) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 12) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 13) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 14) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 15) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 16) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 17) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 18) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 19) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 20) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 21) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 22) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 23) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 24) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 25) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 26) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 27) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 28) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 29) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 30) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 31) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 32) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 33) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 34) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 35) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 36) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 37) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 38) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 39) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 40) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 41) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 42) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 43) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 44) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 45) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 46) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 47) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 48) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 49) is missing.
Warning: '/dev' directory structure is incomplete; device (43, 50) is missing.
Fatal: Failed to create a temporary device


If I revert the patch lilo runs normally.


Best regards,
Mind Booster Noori

- --
==================================================
Marcos Daniel Marado Torres AKA Mind Booster Noori
/"\               http://student.dei.uc.pt/~marado
\ /                       marado@student.dei.uc.pt
 X   ASCII Ribbon Campaign
/ \  against HTML e-mail and Micro$oft attachments
==================================================
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Made with pgp4pine 1.76

iD8DBQFAKZpHmNlq8m+oD34RAkxDAKDNZQyB2od/YodaSfzz5/y42UtN7QCeMOXi
UmmlXpVMpnNUDEqNU/UiviE=
=hxWi
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Critical problem in 2.6.2 and up
  2004-02-11  2:58 Critical problem in 2.6.2 and up Marcos D. Marado Torres
@ 2004-02-11  3:19 ` Andrew Morton
  2004-02-11  3:30   ` Marcos D. Marado Torres
  0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2004-02-11  3:19 UTC (permalink / raw)
  To: Marcos D. Marado Torres; +Cc: linux-kernel

"Marcos D. Marado Torres" <marado@student.dei.uc.pt> wrote:
>
> # lilo
> 
>  Warning: '/proc/partitions' does not match '/dev' directory structure.
>      Name change: '/dev/nbd0' -> '/tmp/dev.0'
>  Warning: '/dev' directory structure is incomplete; device (43, 0) is missing.
>  Warning: '/dev' directory structure is incomplete; device (43, 1) is missing.
>  Warning: '/dev' directory structure is incomplete; device (43, 2) is missing.
>  Warning: '/dev' directory structure is incomplete; device (43, 3) is missing.

Please send us your /proc/partitions with, and without that patch.

If you disable nbd in config, does it help?

Are you using devfs?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Critical problem in 2.6.2 and up
  2004-02-11  3:19 ` Andrew Morton
@ 2004-02-11  3:30   ` Marcos D. Marado Torres
  2004-02-11  3:52     ` Marcos D. Marado Torres
  0 siblings, 1 reply; 6+ messages in thread
From: Marcos D. Marado Torres @ 2004-02-11  3:30 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1389 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 10 Feb 2004, Andrew Morton wrote:

> "Marcos D. Marado Torres" <marado@student.dei.uc.pt> wrote:
> >
> > # lilo
> >
> >  Warning: '/proc/partitions' does not match '/dev' directory structure.
> >      Name change: '/dev/nbd0' -> '/tmp/dev.0'
> >  Warning: '/dev' directory structure is incomplete; device (43, 0) is missing.
> >  Warning: '/dev' directory structure is incomplete; device (43, 1) is missing.
> >  Warning: '/dev' directory structure is incomplete; device (43, 2) is missing.
> >  Warning: '/dev' directory structure is incomplete; device (43, 3) is missing.
>
> Please send us your /proc/partitions with, and without that patch.

Follows as attachment.

> If you disable nbd in config, does it help?

I'm going to try it next.

> Are you using devfs?

No.

- --
==================================================
Marcos Daniel Marado Torres AKA Mind Booster Noori
/"\               http://student.dei.uc.pt/~marado
\ /                       marado@student.dei.uc.pt
 X   ASCII Ribbon Campaign
/ \  against HTML e-mail and Micro$oft attachments
==================================================

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Made with pgp4pine 1.76

iD8DBQFAKaHOmNlq8m+oD34RAkzWAJ92MDzrtJFg024miQjtd1VS71ji6QCgs+9Q
ofQipvRJOPHGaZfy6zVYwVQ=
=wDE4
-----END PGP SIGNATURE-----

[-- Attachment #2: Type: TEXT/PLAIN, Size: 197 bytes --]

major minor  #blocks  name

   3     0   39070080 hda
   3     1   30724281 hda1
   3     2          1 hda2
   3     3    1052257 hda3
   3     5     562243 hda5
   3     6    6731203 hda6

[-- Attachment #3: Type: TEXT/PLAIN, Size: 3927 bytes --]

major minor  #blocks  name

  43     0    2097151 nbd0
  43     1    2097151 nbd1
  43     2    2097151 nbd2
  43     3    2097151 nbd3
  43     4    2097151 nbd4
  43     5    2097151 nbd5
  43     6    2097151 nbd6
  43     7    2097151 nbd7
  43     8    2097151 nbd8
  43     9    2097151 nbd9
  43    10    2097151 nbd10
  43    11    2097151 nbd11
  43    12    2097151 nbd12
  43    13    2097151 nbd13
  43    14    2097151 nbd14
  43    15    2097151 nbd15
  43    16    2097151 nbd16
  43    17    2097151 nbd17
  43    18    2097151 nbd18
  43    19    2097151 nbd19
  43    20    2097151 nbd20
  43    21    2097151 nbd21
  43    22    2097151 nbd22
  43    23    2097151 nbd23
  43    24    2097151 nbd24
  43    25    2097151 nbd25
  43    26    2097151 nbd26
  43    27    2097151 nbd27
  43    28    2097151 nbd28
  43    29    2097151 nbd29
  43    30    2097151 nbd30
  43    31    2097151 nbd31
  43    32    2097151 nbd32
  43    33    2097151 nbd33
  43    34    2097151 nbd34
  43    35    2097151 nbd35
  43    36    2097151 nbd36
  43    37    2097151 nbd37
  43    38    2097151 nbd38
  43    39    2097151 nbd39
  43    40    2097151 nbd40
  43    41    2097151 nbd41
  43    42    2097151 nbd42
  43    43    2097151 nbd43
  43    44    2097151 nbd44
  43    45    2097151 nbd45
  43    46    2097151 nbd46
  43    47    2097151 nbd47
  43    48    2097151 nbd48
  43    49    2097151 nbd49
  43    50    2097151 nbd50
  43    51    2097151 nbd51
  43    52    2097151 nbd52
  43    53    2097151 nbd53
  43    54    2097151 nbd54
  43    55    2097151 nbd55
  43    56    2097151 nbd56
  43    57    2097151 nbd57
  43    58    2097151 nbd58
  43    59    2097151 nbd59
  43    60    2097151 nbd60
  43    61    2097151 nbd61
  43    62    2097151 nbd62
  43    63    2097151 nbd63
  43    64    2097151 nbd64
  43    65    2097151 nbd65
  43    66    2097151 nbd66
  43    67    2097151 nbd67
  43    68    2097151 nbd68
  43    69    2097151 nbd69
  43    70    2097151 nbd70
  43    71    2097151 nbd71
  43    72    2097151 nbd72
  43    73    2097151 nbd73
  43    74    2097151 nbd74
  43    75    2097151 nbd75
  43    76    2097151 nbd76
  43    77    2097151 nbd77
  43    78    2097151 nbd78
  43    79    2097151 nbd79
  43    80    2097151 nbd80
  43    81    2097151 nbd81
  43    82    2097151 nbd82
  43    83    2097151 nbd83
  43    84    2097151 nbd84
  43    85    2097151 nbd85
  43    86    2097151 nbd86
  43    87    2097151 nbd87
  43    88    2097151 nbd88
  43    89    2097151 nbd89
  43    90    2097151 nbd90
  43    91    2097151 nbd91
  43    92    2097151 nbd92
  43    93    2097151 nbd93
  43    94    2097151 nbd94
  43    95    2097151 nbd95
  43    96    2097151 nbd96
  43    97    2097151 nbd97
  43    98    2097151 nbd98
  43    99    2097151 nbd99
  43   100    2097151 nbd100
  43   101    2097151 nbd101
  43   102    2097151 nbd102
  43   103    2097151 nbd103
  43   104    2097151 nbd104
  43   105    2097151 nbd105
  43   106    2097151 nbd106
  43   107    2097151 nbd107
  43   108    2097151 nbd108
  43   109    2097151 nbd109
  43   110    2097151 nbd110
  43   111    2097151 nbd111
  43   112    2097151 nbd112
  43   113    2097151 nbd113
  43   114    2097151 nbd114
  43   115    2097151 nbd115
  43   116    2097151 nbd116
  43   117    2097151 nbd117
  43   118    2097151 nbd118
  43   119    2097151 nbd119
  43   120    2097151 nbd120
  43   121    2097151 nbd121
  43   122    2097151 nbd122
  43   123    2097151 nbd123
  43   124    2097151 nbd124
  43   125    2097151 nbd125
  43   126    2097151 nbd126
  43   127    2097151 nbd127
   3     0   39070080 hda
   3     1   30724281 hda1
   3     2          1 hda2
   3     3    1052257 hda3
   3     5     562243 hda5
   3     6    6731203 hda6

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Critical problem in 2.6.2 and up
  2004-02-11  3:30   ` Marcos D. Marado Torres
@ 2004-02-11  3:52     ` Marcos D. Marado Torres
  2004-02-11  4:02       ` Andrew Morton
  0 siblings, 1 reply; 6+ messages in thread
From: Marcos D. Marado Torres @ 2004-02-11  3:52 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 11 Feb 2004, Marcos D. Marado Torres wrote:

> On Tue, 10 Feb 2004, Andrew Morton wrote:
>
> > "Marcos D. Marado Torres" <marado@student.dei.uc.pt> wrote:
> > >
> > > # lilo
> > >
> > >  Warning: '/proc/partitions' does not match '/dev' directory structure.
> > >      Name change: '/dev/nbd0' -> '/tmp/dev.0'
> > >  Warning: '/dev' directory structure is incomplete; device (43, 0) is missing.
> > >  Warning: '/dev' directory structure is incomplete; device (43, 1) is missing.
> > >  Warning: '/dev' directory structure is incomplete; device (43, 2) is missing.
> > >  Warning: '/dev' directory structure is incomplete; device (43, 3) is missing.
> >
> > Please send us your /proc/partitions with, and without that patch.
>
> Follows as attachment.
>
> > If you disable nbd in config, does it help?
>
> I'm going to try it next.

With nbd disabled the patch causes no problems.



- --
==================================================
Marcos Daniel Marado Torres AKA Mind Booster Noori
/"\               http://student.dei.uc.pt/~marado
\ /                       marado@student.dei.uc.pt
 X   ASCII Ribbon Campaign
/ \  against HTML e-mail and Micro$oft attachments
==================================================

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Made with pgp4pine 1.76

iD8DBQFAKacOmNlq8m+oD34RAnEpAJ0cY/wWddjHors+eTLq/wXaTOHIkgCghKtX
jFnj+FqWRjVUkj0F9l+DYQY=
=PTyn
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Critical problem in 2.6.2 and up
  2004-02-11  3:52     ` Marcos D. Marado Torres
@ 2004-02-11  4:02       ` Andrew Morton
  2004-02-11  4:08         ` Marcos D. Marado Torres
  0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2004-02-11  4:02 UTC (permalink / raw)
  To: Marcos D. Marado Torres; +Cc: linux-kernel

"Marcos D. Marado Torres" <marado@student.dei.uc.pt> wrote:
>
> 
> With nbd disabled the patch causes no problems.
> 

I don't know what LILO's problem is, frankly.  My version is OK with it,
and my /proc/partitions is doing the same as yours.

vmm:/home/akpm>  lilo -V       
LILO version 21.4-4

Still, we probably want to suppress all those NDB majors in
/proc/partitions.  I'll discuss it with the blocky guys.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Critical problem in 2.6.2 and up
  2004-02-11  4:02       ` Andrew Morton
@ 2004-02-11  4:08         ` Marcos D. Marado Torres
  0 siblings, 0 replies; 6+ messages in thread
From: Marcos D. Marado Torres @ 2004-02-11  4:08 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 10 Feb 2004, Andrew Morton wrote:

> "Marcos D. Marado Torres" <marado@student.dei.uc.pt> wrote:
> >
> >
> > With nbd disabled the patch causes no problems.
> >
>
> I don't know what LILO's problem is, frankly.  My version is OK with it,
> and my /proc/partitions is doing the same as yours.
>
> vmm:/home/akpm>  lilo -V
> LILO version 21.4-4

Well, I'm using version 22.5.8 (the last version)... Maybe you could update
LILO and see if that's what causes the problem?

> Still, we probably want to suppress all those NDB majors in
> /proc/partitions.  I'll discuss it with the blocky guys.
>


- --
==================================================
Marcos Daniel Marado Torres AKA Mind Booster Noori
/"\               http://student.dei.uc.pt/~marado
\ /                       marado@student.dei.uc.pt
 X   ASCII Ribbon Campaign
/ \  against HTML e-mail and Micro$oft attachments
==================================================

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Made with pgp4pine 1.76

iD8DBQFAKaqumNlq8m+oD34RAkprAJ9lF/bAIpyyt3Hq1RS7nJeaeMZ5cwCePjih
otu5E51YY1c7dk53r7JQ/RE=
=iXC8
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2004-02-11  4:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-11  2:58 Critical problem in 2.6.2 and up Marcos D. Marado Torres
2004-02-11  3:19 ` Andrew Morton
2004-02-11  3:30   ` Marcos D. Marado Torres
2004-02-11  3:52     ` Marcos D. Marado Torres
2004-02-11  4:02       ` Andrew Morton
2004-02-11  4:08         ` Marcos D. Marado Torres

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®