PPC64 PowerMac G5 support available

PPC64 PowerMac G5 support available

[Benjamin Herrenschmidt]

Hi Linus !

You can pull from bk://ppc.bkbits.net/for-linus-ppc

Curious can inspect the patch using the bkbits web interface

If Andrew prefers keeping it into -mm for a while, I can do a big
patch from the bk tree, though this patch is putting other ppc64
stuffs on hold for now, so it shall go in asap (as it would be too
nasty to deal with conflicts if other things went in at this point).

Linus: you will probably need an updated radeonfb anyway as I told
you. I'll start working on it now and will post a patch separately.

Also, there is currently a known build problem with the zImage wrapper
in 2.6.3-rc2, unrelated to this patch, it doesn't prevent the build of
the plain vmlinux which is what yaboot uses on the G5.

Finally, ieee1394 triggers an oops in kobject since 2.6.3-rc2, 100%
reproduceable for me (and apparently x86 users too), so that's also
unrelated to the G5 code.

Ben.

Re: PPC64 PowerMac G5 support available

[Linus Torvalds]

On Thu, 12 Feb 2004, Benjamin Herrenschmidt wrote:
> 
> You can pull from bk://ppc.bkbits.net/for-linus-ppc

Pulling. And yes, I didn't realize that the whole aty/radeon driver was 
new. Regardless, the bits above look obvious enough, and I'll take the new 
radeon driver too once it's ready.

> Finally, ieee1394 triggers an oops in kobject since 2.6.3-rc2, 100%
> reproduceable for me (and apparently x86 users too), so that's also
> unrelated to the G5 code.

Hmm.. I've got ieee1394 built into my standard machine without any oopses,
but I don't have any actual devices connected to it, just the host. I 
assume the problems happen only with devices plugged in?

		Linus

Re: PPC64 PowerMac G5 support available

[Linus Torvalds]

On Thu, 12 Feb 2004, Benjamin Herrenschmidt wrote:
> 
> Linus: you will probably need an updated radeonfb anyway as I told
> you. I'll start working on it now and will post a patch separately.

Actually, at least for me, the _old_ radeon driver works without any 
modifications at all in text mode. Rock stable image, unlike the new one 
that needed the clock fixes.

But trying to start X hangs the system hard, which may well be an issue 
with the old radeonfb. Whenever you have a new driver, I will test.

> Also, there is currently a known build problem with the zImage wrapper
> in 2.6.3-rc2, unrelated to this patch, it doesn't prevent the build of
> the plain vmlinux which is what yaboot uses on the G5.

Actually, there's another issue, which is that the default G5 config 
enables drivers/serial/pmac_zilog.c, which has a

	#include <asm/kgdb.h>

in it that will cause the build to fail.

Anyway, with that fixed, it will compile and appears to work on the G5. 
Thanks. Although I did see it hang when I inserted a USB keyboard (in 
addition to the X problem). Hmm.

		Linus

Re: PPC64 PowerMac G5 support available

[Anton Blanchard]

 
> Actually, at least for me, the _old_ radeon driver works without any 
> modifications at all in text mode. Rock stable image, unlike the new one 
> that needed the clock fixes.
> 
> But trying to start X hangs the system hard, which may well be an issue 
> with the old radeonfb. Whenever you have a new driver, I will test.

Chances are you are using the openfirmware FB stuff, not radeonFB. Ben
suggested checking out /proc/fb or dmesg to be sure.

Anton

Re: PPC64 PowerMac G5 support available

[Benjamin Herrenschmidt]

> Actually, there's another issue, which is that the default G5 config 
> enables drivers/serial/pmac_zilog.c, which has a
> 
> 	#include <asm/kgdb.h>
> 
> in it that will cause the build to fail.

So here's the patch :)

===== drivers/serial/pmac_zilog.c 1.3 vs edited =====
--- 1.3/drivers/serial/pmac_zilog.c	Thu Feb 12 15:50:41 2004
+++ edited/drivers/serial/pmac_zilog.c	Thu Feb 12 18:14:00 2004
@@ -59,7 +59,6 @@
 #include <asm/bitops.h>
 #include <asm/machdep.h>
 #include <asm/pmac_feature.h>
-#include <asm/kgdb.h>
 #include <asm/dbdma.h>
 #include <asm/macio.h>
 

Re: PPC64 PowerMac G5 support available

[Benjamin Herrenschmidt]

BTW. Please do:

bk rm include/asm-ppc64/offsets.h

This file is generated, it's plain wrong to distribute one and
could explain all sorts of strange things :)

(It contains the offsets into some kernel data structures to be
used by the asm code)

Andrew: If you have such a file in your tree, remove it from the
distribution too. I'll check if it's part of the make distclean
process, I'm afraid it may not...

Ben.

Re: PPC64 PowerMac G5 support available

[Linus Torvalds]

On Thu, 12 Feb 2004, Benjamin Herrenschmidt wrote:
> 
> Finally, ieee1394 triggers an oops in kobject since 2.6.3-rc2, 100%
> reproduceable for me (and apparently x86 users too), so that's also
> unrelated to the G5 code.

Does the appended fix it?

		Linus

---
===== drivers/base/bus.c 1.52 vs edited =====
--- 1.52/drivers/base/bus.c	Tue Sep 30 08:59:35 2003
+++ edited/drivers/base/bus.c	Thu Feb 12 07:40:44 2004
@@ -158,17 +158,18 @@
 int bus_for_each_dev(struct bus_type * bus, struct device * start, 
 		     void * data, int (*fn)(struct device *, void *))
 {
-	struct list_head * head, * entry;
+	struct device *dev;
+	struct list_head * head;
 	int error = 0;
 
 	if (!(bus = get_bus(bus)))
 		return -EINVAL;
 
-	head = start ? &start->bus_list : &bus->devices.list;
+	head = &bus->devices.list;
+	dev = start ? : to_dev(head);
 
 	down_read(&bus->subsys.rwsem);
-	list_for_each(entry,head) {
-		struct device * dev = get_device(to_dev(entry));
+	list_for_each_entry_continue(dev, head, node) {
 		error = fn(dev,data);
 		put_device(dev);
 		if (error)

Re: PPC64 PowerMac G5 support available

[Linus Torvalds]

On Thu, 12 Feb 2004, Linus Torvalds wrote:
> 
> Does the appended fix it?

It can't, since it's missing a "get_device()" at the top of the loop.  But 
with that fixed it should hopefully be gone.. (Noted by Ben Collins)

		Linus