Strange problem with emu10k1 and gcc-3.4

Strange problem with emu10k1 and gcc-3.4

[J.A. Magallon]

Hi al...

I have tried to build 2.6.3-rc2-mm1 with gcc-3.4, and it works apart from this:

werewolf:/boot# modprobe emu10k1
FATAL: Error inserting emu10k1 (/lib/modules/2.6.3-rc1-jam1-gcc34/kernel/sound/oss/emu10k1/emu10k1.ko): Unknown symbol in module, or unknown parameter (see dmesg)

dmesg:
...
emu10k1: Unknown symbol strcpy

I think this solves the problem:

--- linux-2.6.3-rc2-jam1/sound/oss/emu10k1/efxmgr.h.orig	2004-02-12 23:55:14.210762109 +0100
+++ linux-2.6.3-rc2-jam1/sound/oss/emu10k1/efxmgr.h	2004-02-12 23:56:02.771954542 +0100
@@ -32,6 +32,8 @@
 #ifndef _EFXMGR_H
 #define _EFXMGR_H
 
+#include <linux/string.h>
+
 struct emu_efx_info_t{
 	int opcode_shift;
 	int high_operand_shift;

The strange thing is: why depmod -ae does not show any problem ?

TIA

-- 
J.A. Magallon <jamagallon()able!es>     \                 Software is like sex:
werewolf!able!es                         \           It's better when it's free
Mandrake Linux release 10.0 (Cooker) for i586
Linux 2.6.3-rc1-jam1-gcc34 (gcc 3.4.0 (Mandrake Linux 10.0 3.4.0-0.1mdk))

Re: Strange problem with emu10k1 and gcc-3.4

[J.A. Magallon]

On 02.13, J.A. Magallon wrote:
> Hi al...
> 
> I have tried to build 2.6.3-rc2-mm1 with gcc-3.4, and it works apart from this:
> 
> werewolf:/boot# modprobe emu10k1
> FATAL: Error inserting emu10k1 (/lib/modules/2.6.3-rc1-jam1-gcc34/kernel/sound/oss/emu10k1/emu10k1.ko): Unknown symbol in module, or unknown parameter (see dmesg)
> 
> dmesg:
> ...
> emu10k1: Unknown symbol strcpy
> 
> I think this solves the problem:
> 

Nope, that was not enough. Any ideas ?

-- 
J.A. Magallon <jamagallon()able!es>     \                 Software is like sex:
werewolf!able!es                         \           It's better when it's free
Mandrake Linux release 10.0 (Cooker) for i586
Linux 2.6.3-rc2-jam1 (gcc 3.4.0 (Mandrake Linux 10.0 3.4.0-0.1mdk))

Re: Strange problem with emu10k1 and gcc-3.4

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]

On Fri, 13 Feb 2004 00:18:02 +0100, "J.A. Magallon" <jamagallon@able.es>  said:
> Hi al...
> 
> I have tried to build 2.6.3-rc2-mm1 with gcc-3.4, and it works apart from thi
s:

> emu10k1: Unknown symbol strcpy
> 

Alternate fix for a similar problem I hit is appended.  Basically, if
gcc-3.4 fails to inline all of them, we need to have a copy that's visible
from a module.

(Oh, the '#undef memcmp' was needed because memcmp was #defined to
__inline_memcmp so the wrong thing got EXPORT_SYMBOL'ed...)

I'll submit an extended patch that does all of string.c if people think
it's a good idea.

--- linux-2.6.2-rc1-mm1/lib/string.c.dist	2004-01-22 17:20:00.859598882 -0500
+++ linux-2.6.2-rc1-mm1/lib/string.c	2004-01-22 17:29:43.316730389 -0500
@@ -501,6 +501,9 @@
 #endif
 
 #ifndef __HAVE_ARCH_MEMCMP
+#ifdef memcmp
+#undef memcmp
+#endif
 /**
  * memcmp - Compare two areas of memory
  * @cs: One area of memory
@@ -517,6 +520,7 @@
 			break;
 	return res;
 }
+EXPORT_SYMBOL(memcmp);
 #endif
 
 #ifndef __HAVE_ARCH_MEMSCAN



[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]