[SELINUX] mark avc_init with __init

[SELINUX] mark avc_init with __init

[James Morris]

The avc_init function is only called during kernel init, so it can be 
marked with __init.

Please apply.


- James
-- 
James Morris
<jmorris@redhat.com>

diff -urN -X dontdiff linux-2.6.3-rc2-mm1.o/security/selinux/avc.c linux-2.6.3-rc2-mm1.w2/security/selinux/avc.c
--- linux-2.6.3-rc2-mm1.o/security/selinux/avc.c	2004-02-04 08:39:07.000000000 -0500
+++ linux-2.6.3-rc2-mm1.w2/security/selinux/avc.c	2004-02-13 09:21:38.703303568 -0500
@@ -166,7 +166,7 @@
  *
  * Initialize the access vector cache.
  */
-void avc_init(void)
+void __init avc_init(void)
 {
 	struct avc_node	*new;
 	int i;
diff -urN -X dontdiff linux-2.6.3-rc2-mm1.o/security/selinux/include/avc.h linux-2.6.3-rc2-mm1.w2/security/selinux/include/avc.h
--- linux-2.6.3-rc2-mm1.o/security/selinux/include/avc.h	2004-02-04 08:39:07.000000000 -0500
+++ linux-2.6.3-rc2-mm1.w2/security/selinux/include/avc.h	2004-02-13 09:21:38.704303416 -0500
@@ -11,6 +11,7 @@
 #include <linux/kernel.h>
 #include <linux/kdev_t.h>
 #include <linux/spinlock.h>
+#include <linux/init.h>
 #include <asm/system.h>
 #include "flask.h"
 #include "av_permissions.h"
@@ -121,7 +122,7 @@
  * AVC operations
  */
 
-void avc_init(void);
+void __init avc_init(void);
 
 int avc_lookup(u32 ssid, u32 tsid, u16 tclass,
                u32 requested, struct avc_entry_ref *aeref);

Re: [SELINUX] mark avc_init with __init

[Andrew Morton]

James Morris <jmorris@redhat.com> wrote:
>
> The avc_init function is only called during kernel init, so it can be 
> marked with __init.
> 
> ...
> --- linux-2.6.3-rc2-mm1.o/security/selinux/include/avc.h	2004-02-04 08:39:07.000000000 -0500
> +++ linux-2.6.3-rc2-mm1.w2/security/selinux/include/avc.h	2004-02-13 09:21:38.704303416 -0500
> @@ -11,6 +11,7 @@
>  #include <linux/kernel.h>
>  #include <linux/kdev_t.h>
>  #include <linux/spinlock.h>
> +#include <linux/init.h>
>  #include <asm/system.h>
>  #include "flask.h"
>  #include "av_permissions.h"
> @@ -121,7 +122,7 @@
>   * AVC operations
>   */
>  
> -void avc_init(void);
> +void __init avc_init(void);
>  

The section specifier only needs to be at the definition site, not at the
declaration site.  I guess it adds a little value for the header fle to say
"hey, this is __init", but as nothing checks that at runtime or compile
time it can easily become stale.