From: Rusty Russell <rusty@rustcorp.com.au>
To: torvalds@osdl.org, akpm@osdl.org
Cc: Keith M Wesolowski <wesolows@foobazco.org>, linux-kernel@vger.kernel.org
Subject: [PATCH]: Sparc no longer Fucked Up
Date: Sun, 15 Feb 2004 13:44:43 +1100 [thread overview]
Message-ID: <20040215070352.1B07F2C0F8@lists.samba.org> (raw)
From: Keith M Wesolowski <wesolows@foobazco.org>
As of 2.6.3, restore_flags will no longer modify cwp on sparc.
Therefore you can apply this patch to the locking guide.
[ Indeed. I'll also remove the atomic comments from Hacking
Guide as part of my revision there when I get back to it. --RR ]
diff -Nru a/Documentation/DocBook/kernel-locking.tmpl b/Documentation/DocBook/kernel-locking.tmpl
--- a/Documentation/DocBook/kernel-locking.tmpl Sun Feb 8 15:07:26 2004
+++ b/Documentation/DocBook/kernel-locking.tmpl Sun Feb 8 15:07:26 2004
@@ -1444,27 +1444,6 @@
</para>
</sect1>
- <sect1 id="sparc">
- <title>The Fucked Up Sparc</title>
-
- <para>
- Alan Cox says <quote>the irq disable/enable is in the register
- window on a sparc</quote>. Andi Kleen says <quote>when you do
- restore_flags in a different function you mess up all the
- register windows</quote>.
- </para>
-
- <para>
- So never pass the flags word set by
- <function>spin_lock_irqsave()</function> and brethren to another
- function (unless it's declared <type>inline</type>). Usually no-one
- does this, but now you've been warned. Dave Miller can never do
- anything in a straightforward manner (I can say that, because I have
- pictures of him and a certain PowerPC maintainer in a compromising
- position).
- </para>
- </sect1>
-
</chapter>
<chapter id="Efficiency">
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
reply other threads:[~2004-02-15 7:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040215070352.1B07F2C0F8@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=wesolows@foobazco.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®