From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Keith Owens <kaos@sgi.com>, linux-kernel@vger.kernel.org
Cc: Russell King <rmk@arm.linux.org.uk>
Subject: Re: 2.6.3-rc3 serial console woes
Date: Mon, 16 Feb 2004 12:07:56 -0700 [thread overview]
Message-ID: <200402161207.56284.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <3326.1076937262@ocs3.ocs.com.au>
On Monday 16 February 2004 6:14 am, Keith Owens wrote:
> Between 2.6.3-rc2 and 2.6.3-rc3, the serial console initialisation
> changed, due to this patch :-
>
> http://linux.bkbits.net:8080/linux-2.5/cset@1.1653?nav=index.html|ChangeSet@-7d
>
> Now the serial console is not initialised until a long way into the
> boot, just after the disks are probed. This makes it impossible to use
> a kernel debugger such as kdb or kgdb over a serial console during
> device initialisation.
Hmm.... I suspect the problem is that serial8250_isa_init_ports()
doesn't initialize port->type for the ports in SERIAL_PORT_DFNS,
so we fail the console setup.
Does the attached patch make it work like it used to? ISTR that
Russell didn't really like testing port->ops, but I can't remember
why, and I don't see anything better.
===== drivers/serial/8250.c 1.44 vs edited =====
--- 1.44/drivers/serial/8250.c Fri Feb 13 08:19:33 2004
+++ edited/drivers/serial/8250.c Mon Feb 16 12:03:06 2004
@@ -1976,7 +1976,7 @@
if (co->index >= UART_NR)
co->index = 0;
port = &serial8250_ports[co->index].port;
- if (port->type == PORT_UNKNOWN)
+ if (!port->ops)
return -ENODEV;
/*
next prev parent reply other threads:[~2004-02-16 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 13:14 Keith Owens
2004-02-16 19:07 ` Bjorn Helgaas [this message]
2004-02-16 21:05 ` Keith Owens
2004-02-16 23:25 ` Keith Owens
2004-02-16 23:45 ` Bjorn Helgaas
2004-02-17 1:53 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402161207.56284.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®