mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>
Subject: Re: 2.6.3-rc3 serial console woes
Date: Mon, 16 Feb 2004 16:45:14 -0700	[thread overview]
Message-ID: <200402161645.14151.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <2719.1076973910@kao2.melbourne.sgi.com>

On Monday 16 February 2004 4:25 pm, Keith Owens wrote:
> Spoke too soon.  That one line patch makes the serial console available
> early in boot.  But as soon as /sbin/init runs, the console is
> gibberish due to a speed mismatch.  Completely reverting
> 
>   http://linux.bkbits.net:8080/linux-2.5/cset@1.1653?nav=index.html|ChangeSet@-7d
> 
> works fine.  Since this is a -rc kernel, can we revert the cset until
> it is fixed?

Reverting for now sounds like the right thing to me.  I would like to
understand what's going on, though.

For the serial console to work early, serial8250_console_setup() must
be returning zero.  So we can't be taking this return:

	if (!port->ops)
		return -ENODEV;

and therefore, the hunk in serial_core.c shouldn't have any effect either.
So is it merely the fact that we call serial8250_late_console_init()?

I wouldn't expect that to make any difference, because the setup()
call from serial8250_console_init() should have succeeded, so
CON_ENABLED should have been set, and we don't do anything in
that case.

Keith, can you tell me how to reproduce this?

Bjorn


  reply	other threads:[~2004-02-16 23:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-16 13:14 Keith Owens
2004-02-16 19:07 ` Bjorn Helgaas
2004-02-16 21:05   ` Keith Owens
2004-02-16 23:25     ` Keith Owens
2004-02-16 23:45       ` Bjorn Helgaas [this message]
2004-02-17  1:53         ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200402161645.14151.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®