Re: [PATCH][6/6] A different KGDB stub

[Tom Rini <trini@kernel.crashing.org>]

On Wed, Feb 18, 2004 at 12:08:55AM +0100, Pavel Machek wrote:
> Hi!
> 
> > > > The following is the x86_64-specific bits to this KGDB stub (Pavel, can
> > > > you give this a try please?  Thanks).
> > > 
> > > I can only see [0/6],[1/6] and [6/6] on l-k. Could you perhaps mail me
> > > complete diff against 2.6.2 to try? [Or against some other version I
> > > can get from kernel.org...)
> > 
> > I'll blame the slow mailserver and hope they all get through
> > eventually.
> 
> Yes, now only #2 is missing :-))).
> 
> > The following is the patch before I split it up.  Against 2.6.3-rc4 +
> > bk-netdev from 2.6.3-rc3-mm1 (otherwise kgdboe won't work at all):
> 
> I'll try without kgdboe, first.
> 
> I'm getting some compile errors, stay tuned.

I'm not surprised, sadly.

> Meanwhile: [and taking this public]
> 
> arch/x86_64/kernel/x86_64-stub.c: this is really horrible name for a
> file. Can we have arch/x86_64/kernel/kgdb.c? or kgdb-stub.c at worst..
> 
> also kernel/kgdb.c sounds better than kernel/kgdbstub.c.

Don't look at me for naming, when in doubt I call stuff 'simple' (see
arch/ppc/boot/simple, or CONFIG_PPC_SIMPLE_SERIAL, and I'm sure I'll do
it again).  If people like kernel/kgdb.c (and arch/$(ARCH)/kernel/kgdb.c
or kgdb-stub.c) that's fine with me, so long as they're all consistent.

-- 
Tom Rini
http://gate.crashing.org/~trini/