From: viro@parcelfarce.linux.theplanet.co.uk
To: Dave Jones <davej@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Santiago Leon <santil@us.ibm.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH][2.6] IBM PowerPC Virtual Ethernet Driver
Date: Wed, 18 Feb 2004 04:23:40 +0000 [thread overview]
Message-ID: <20040218042340.GW8858@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040218040130.GC26304@redhat.com>
On Wed, Feb 18, 2004 at 04:01:30AM +0000, Dave Jones wrote:
> On Wed, Feb 18, 2004 at 11:45:20AM +1100, Benjamin Herrenschmidt wrote:
>
> > BITFIELDS ARE EVIL !!!
> >
> > Especially when mapping things like HW registers... I know the p/iSeries
> > code is full of them, I'd strongly recommend getting rid of them.
> >
> > The compiler is perfectly free, afaik, to re-order them
>
> That can't be right surely ? That would make them utterly useless afaics.
> I've not seen this happen in practice either with the 2 x86 cpufreq drivers
> I wrote that both use bitfields extensively.
It _is_ right and they are utterly useless. Original rationale was, indeed,
"describe the layout of hardware registers" but it had gone to hell may years
ago. Any assumptions regarding their allocation are non-portable.
next prev parent reply other threads:[~2004-02-18 4:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-17 22:48 Santiago Leon
2004-02-18 0:45 ` Benjamin Herrenschmidt
2004-02-18 4:01 ` Dave Jones
2004-02-18 4:23 ` viro [this message]
2004-02-18 4:46 ` Linus Torvalds
2004-02-18 5:03 ` Benjamin Herrenschmidt
2004-02-18 16:39 ` Linus Torvalds
2004-02-18 5:04 ` viro
2004-02-18 4:19 ` Keith Owens
2004-02-18 4:42 ` Andrew Morton
2004-02-18 4:48 ` Linus Torvalds
2004-02-20 23:26 ` Santiago Leon
2004-02-22 22:11 ` Pavel Machek
2004-02-26 5:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040218042340.GW8858@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=benh@kernel.crashing.org \
--cc=davej@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=santil@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®