mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Alexander Atanasov <alex@ssi.bg>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] runtime PM deadlock
Date: Sun, 22 Feb 2004 17:28:49 -0800	[thread overview]
Message-ID: <20040222172849.76633696.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0402221908540.13861@mars.home.zaxl.net>

Alexander Atanasov <alex@ssi.bg> wrote:
>
> 	Hello,
> 
> 	echo -n 3 > /sys/.../power/state; echo -n 2 > /sys/.../power/state
> 
> 	dpm_runtime_suspend holds dpm_sem and calls
> dpm_runtime_resume which deadlocks, instead
> directly call runtime_resume.
> 
> -- 
> have fun,
> alex
> 
> ===== drivers/base/power/runtime.c 1.2 vs edited =====
> --- 1.2/drivers/base/power/runtime.c	Wed Aug 20 09:23:32 2003
> +++ edited/drivers/base/power/runtime.c	Sun Feb 22 18:26:42 2004
> @@ -51,7 +51,7 @@
>  		goto Done;
> 
>  	if (dev->power.power_state)
> -		dpm_runtime_resume(dev);
> +		runtime_resume(dev);
> 
>  	if (!(error = suspend_device(dev,state)))
>  		dev->power.power_state = state;

heh, that's been there since day one.   Thanks.


      reply	other threads:[~2004-02-23  1:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-22 17:40 Alexander Atanasov
2004-02-23  1:28 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040222172849.76633696.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=alex@ssi.bg \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®