mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] runtime PM deadlock
@ 2004-02-22 17:40 Alexander Atanasov
  2004-02-23  1:28 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Atanasov @ 2004-02-22 17:40 UTC (permalink / raw)
  To: linux-kernel

	Hello,

	echo -n 3 > /sys/.../power/state; echo -n 2 > /sys/.../power/state

	dpm_runtime_suspend holds dpm_sem and calls
dpm_runtime_resume which deadlocks, instead
directly call runtime_resume.

-- 
have fun,
alex

===== drivers/base/power/runtime.c 1.2 vs edited =====
--- 1.2/drivers/base/power/runtime.c	Wed Aug 20 09:23:32 2003
+++ edited/drivers/base/power/runtime.c	Sun Feb 22 18:26:42 2004
@@ -51,7 +51,7 @@
 		goto Done;

 	if (dev->power.power_state)
-		dpm_runtime_resume(dev);
+		runtime_resume(dev);

 	if (!(error = suspend_device(dev,state)))
 		dev->power.power_state = state;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] runtime PM deadlock
  2004-02-22 17:40 [PATCH] runtime PM deadlock Alexander Atanasov
@ 2004-02-23  1:28 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2004-02-23  1:28 UTC (permalink / raw)
  To: Alexander Atanasov; +Cc: linux-kernel

Alexander Atanasov <alex@ssi.bg> wrote:
>
> 	Hello,
> 
> 	echo -n 3 > /sys/.../power/state; echo -n 2 > /sys/.../power/state
> 
> 	dpm_runtime_suspend holds dpm_sem and calls
> dpm_runtime_resume which deadlocks, instead
> directly call runtime_resume.
> 
> -- 
> have fun,
> alex
> 
> ===== drivers/base/power/runtime.c 1.2 vs edited =====
> --- 1.2/drivers/base/power/runtime.c	Wed Aug 20 09:23:32 2003
> +++ edited/drivers/base/power/runtime.c	Sun Feb 22 18:26:42 2004
> @@ -51,7 +51,7 @@
>  		goto Done;
> 
>  	if (dev->power.power_state)
> -		dpm_runtime_resume(dev);
> +		runtime_resume(dev);
> 
>  	if (!(error = suspend_device(dev,state)))
>  		dev->power.power_state = state;

heh, that's been there since day one.   Thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-02-23  1:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-22 17:40 [PATCH] runtime PM deadlock Alexander Atanasov
2004-02-23  1:28 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®