* [PATCH] scripts/modpost warning
@ 2004-02-29 16:15 Geert Uytterhoeven
2004-03-01 6:00 ` Rusty Russell
2004-03-01 14:02 ` Kai Germaschewski
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2004-02-29 16:15 UTC (permalink / raw)
To: Kai Germaschewski, Paul Russell; +Cc: Linux Kernel Development
I need the following patch to kill a warning (__endian() may be unused) when
cross-compiling m68k kernels on an ia32 box.
--- linux-2.6.4-rc1/scripts/modpost.h 2004-02-29 09:33:41.000000000 +0100
+++ linux-m68k-2.6.4-rc1/scripts/modpost.h 2004-02-29 10:39:56.000000000 +0100
@@ -31,7 +31,7 @@
#if KERNEL_ELFDATA != HOST_ELFDATA
-static void __endian(const void *src, void *dest, unsigned int size)
+static inline void __endian(const void *src, void *dest, unsigned int size)
{
unsigned int i;
for (i = 0; i < size; i++)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/modpost warning
2004-02-29 16:15 [PATCH] scripts/modpost warning Geert Uytterhoeven
@ 2004-03-01 6:00 ` Rusty Russell
2004-03-01 14:02 ` Kai Germaschewski
1 sibling, 0 replies; 3+ messages in thread
From: Rusty Russell @ 2004-03-01 6:00 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linux Kernel Development, torvalds
In message <Pine.GSO.4.58.0402291713230.7483@waterleaf.sonytel.be> you write:
>
> I need the following patch to kill a warning (__endian() may be unused) when
> cross-compiling m68k kernels on an ia32 box.
Yep. sumversion.c doesn't actually use this routine.
Please apply.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
I need the following patch to kill a warning (__endian() may be unused) when
cross-compiling m68k kernels on an ia32 box.
sumversion.c include modpost.h for grab_file and release_file, and
doesn't use __endian.
--- linux-2.6.4-rc1/scripts/modpost.h 2004-02-29 09:33:41.000000000 +0100
+++ linux-m68k-2.6.4-rc1/scripts/modpost.h 2004-02-29 10:39:56.000000000 +0100
@@ -31,7 +31,7 @@
#if KERNEL_ELFDATA != HOST_ELFDATA
-static void __endian(const void *src, void *dest, unsigned int size)
+static inline void __endian(const void *src, void *dest, unsigned int size)
{
unsigned int i;
for (i = 0; i < size; i++)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/modpost warning
2004-02-29 16:15 [PATCH] scripts/modpost warning Geert Uytterhoeven
2004-03-01 6:00 ` Rusty Russell
@ 2004-03-01 14:02 ` Kai Germaschewski
1 sibling, 0 replies; 3+ messages in thread
From: Kai Germaschewski @ 2004-03-01 14:02 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Paul Russell, Linux Kernel Development
On Sun, 29 Feb 2004, Geert Uytterhoeven wrote:
> --- linux-2.6.4-rc1/scripts/modpost.h 2004-02-29 09:33:41.000000000 +0100
> +++ linux-m68k-2.6.4-rc1/scripts/modpost.h 2004-02-29 10:39:56.000000000 +0100
> @@ -31,7 +31,7 @@
>
> #if KERNEL_ELFDATA != HOST_ELFDATA
>
> -static void __endian(const void *src, void *dest, unsigned int size)
> +static inline void __endian(const void *src, void *dest, unsigned int size)
> {
> unsigned int i;
> for (i = 0; i < size; i++)
Looks good to me.
Rusty, can you put this on your trival patches queue?
--Kai
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-03-01 14:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-29 16:15 [PATCH] scripts/modpost warning Geert Uytterhoeven
2004-03-01 6:00 ` Rusty Russell
2004-03-01 14:02 ` Kai Germaschewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®