From: Andi Kleen <ak@suse.de>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org
Subject: Re: [PATCH] 2.6.4-rc1 fix x86 early_printk and make it early
Date: Mon, 1 Mar 2004 11:58:13 +0100 [thread overview]
Message-ID: <20040301115813.6194f2fe.ak@suse.de> (raw)
In-Reply-To: <m165dp9m2r.fsf@ebiederm.dsl.xmission.com>
On 29 Feb 2004 22:24:12 -0700
ebiederm@xmission.com (Eric W. Biederman) wrote:
> o That is problematic with PAE support, because there is a moment
> during paging_init() when the physical identity mappings do not
> work.
Just don't printk in that moment then.
> o Using raw physical addresses is in bad form, and doesn't always work.
On x86-64 it's that __pa() doesn't always work very early.
> o I can't possibly see how Andrew's Changelog that using __pa
> is more friendly to the 4G/4G split is correct. Unless someone
> was hard coding a virtual address previously.
Yes, it shouldn't make any difference for 4/4.
> The second hunk in early_printk.c redefines VGABASE as __va(0xb8000).
> This is correct on both x86 and x86-64 so we don't need any more
> special cases.
Please don't do that on x86-64. On x86-64 there are two ways to reach this
address and the previous one is available earlier. Keep the current
address for x86-64 please.
-Andi
next prev parent reply other threads:[~2004-03-01 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-01 5:24 Eric W. Biederman
2004-03-01 10:58 ` Andi Kleen [this message]
2004-03-01 15:47 ` Eric W. Biederman
2004-03-02 8:21 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040301115813.6194f2fe.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®