From: Chip Salzenberg <chip@pobox.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] 2.6.3: re-enable UHCI interrupts on APM resume
Date: Mon, 1 Mar 2004 18:18:23 -0500 [thread overview]
Message-ID: <20040301231822.GB14500@perlsupport.com> (raw)
Alan Stern wrote the below patch which fixes a lockup problem with USB
on the ThinkPad A30. It's small, helpful, and not ThinkPad-specific.
So, although it will already be part of the next USB merge, I wanted
you to see it. Maybe you'll find it worth including in 2.6.4.
--- 2.6/drivers/usb/host/uhci-hcd.c.orig Fri Feb 20 15:04:41 2004
+++ 2.6/drivers/usb/host/uhci-hcd.c Sun Feb 22 15:23:59 2004
@@ -2471,9 +2471,16 @@
pci_set_master(to_pci_dev(uhci_dev(uhci)));
- if (uhci->state == UHCI_SUSPENDED)
+ if (uhci->state == UHCI_SUSPENDED) {
+
+ /*
+ * Some systems clear the Interrupt Enable register during
+ * PM suspend/resume, so reinitialize it.
+ */
+ outw(USBINTR_TIMEOUT | USBINTR_RESUME | USBINTR_IOC |
+ USBINTR_SP, uhci->io_addr + USBINTR);
uhci->resume_detect = 1;
- else {
+ } else {
reset_hc(uhci);
start_hc(uhci);
}
--
Chip Salzenberg - a.k.a. - <chip@pobox.com>
"I wanted to play hopscotch with the impenetrable mystery of existence,
but he stepped in a wormhole and had to go in early." // MST3K
reply other threads:[~2004-03-01 23:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040301231822.GB14500@perlsupport.com \
--to=chip@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®