mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] 2.6.3: re-enable UHCI interrupts on APM resume
@ 2004-03-01 23:18 Chip Salzenberg
  0 siblings, 0 replies; only message in thread
From: Chip Salzenberg @ 2004-03-01 23:18 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux Kernel

Alan Stern wrote the below patch which fixes a lockup problem with USB
on the ThinkPad A30.  It's small, helpful, and not ThinkPad-specific.

So, although it will already be part of the next USB merge, I wanted
you to see it.  Maybe you'll find it worth including in 2.6.4.

--- 2.6/drivers/usb/host/uhci-hcd.c.orig	Fri Feb 20 15:04:41 2004
+++ 2.6/drivers/usb/host/uhci-hcd.c	Sun Feb 22 15:23:59 2004
@@ -2471,9 +2471,16 @@
 
 	pci_set_master(to_pci_dev(uhci_dev(uhci)));
 
-	if (uhci->state == UHCI_SUSPENDED)
+	if (uhci->state == UHCI_SUSPENDED) {
+
+		/*
+		 * Some systems clear the Interrupt Enable register during
+		 * PM suspend/resume, so reinitialize it.
+		 */
+		outw(USBINTR_TIMEOUT | USBINTR_RESUME | USBINTR_IOC |
+				USBINTR_SP, uhci->io_addr + USBINTR);
 		uhci->resume_detect = 1;
-	else {
+	} else {
 		reset_hc(uhci);
 		start_hc(uhci);
 	}


-- 
Chip Salzenberg               - a.k.a. -               <chip@pobox.com>
"I wanted to play hopscotch with the impenetrable mystery of existence,
    but he stepped in a wormhole and had to go in early."  // MST3K

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-03-01 23:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-01 23:18 [PATCH] 2.6.3: re-enable UHCI interrupts on APM resume Chip Salzenberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®