i2c_use_client broken

i2c_use_client broken

[Kevin O'Connor]

Hi Greg,

In 2.6.3's i2c-core.c there is the following code:

static int i2c_inc_use_client(struct i2c_client *client)
{

        if (!try_module_get(client->driver->owner))
                return -ENODEV;
        if (!try_module_get(client->adapter->owner)) {
                module_put(client->driver->owner);
                return -ENODEV;
        }

        return 0;
}
[...]
int i2c_use_client(struct i2c_client *client)
{
        if (!i2c_inc_use_client(client))
                return -ENODEV;
[...]

The i2c_inc_use_client test looks backward - the code should look like:

        if (i2c_inc_use_client(client))
                return -ENODEV;

because i2c_inc_use_client returns 0 on success.

If I've missed something, please let me know.  I apologize if you're not
the right person to mail or if this has already been fixed.

-Kevin

-- 
 ---------------------------------------------------------------------
 | Kevin O'Connor                  "BTW, IMHO we need a FAQ for      |
 | kevin@koconnor.net               'IMHO', 'FAQ', 'BTW', etc. !"    |
 ---------------------------------------------------------------------

Re: i2c_use_client broken

[Greg KH]

On Thu, Mar 04, 2004 at 01:34:46AM -0500, Kevin O'Connor wrote:
> The i2c_inc_use_client test looks backward - the code should look like:
> 
>         if (i2c_inc_use_client(client))
>                 return -ENODEV;

Russell King just sent me a patch to fix this.

thanks,

greg k-h