Re: [2.6.4-rc2] bogus semicolon behind if()

[Philippe Elie <phil.el@wanadoo.fr>]

On Tue, 09 Mar 2004 at 12:08 +0000, Thomas Schlichter wrote:

> As I wrote a few days ago I have problems with that ChangeSet,
>   (http://marc.theaimsgroup.com/?l=linux-kernel&m=107840458123059&w=2)
> so I did examine it closer.

errmm, http://tinyurl.com/2jbe4

Maciej, you wrote this patch, any comment ?

> so I did examine it closer.
> 
> My results are:
> 1. The semicolons behind the if()'s cannot be there intentionally.
> 2. To fix my problem, timer_ack must be set to 1 for my (integrated) APIC, and 
> as my CPU has a TSC, this cannot be correct for me:
> -	timer_ack = 1;
> +	if (nmi_watchdog == NMI_IO_APIC && !APIC_INTEGRATED(ver))
> +		timer_ack = 1;
> +	else
> +		timer_ack = !cpu_has_tsc;

I don't get the figure, this code in check_timer() is called by
setup_IO_APIC so APIC_INTEGRATED(ver) is always 0 ?


> I changed that if(...) to
> 	if (nmi_watchdog == NMI_IO_APIC || APIC_INTEGRATED(ver))
> which works fine for me here, but I am not 100% sure if this is what the 
> author of the original patch ment and if it still fixes the original 
> problem...
 

regards,
Phil