From: Mikael Pettersson <mikpe@csd.uu.se>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, macro@ds2.pg.gda.pl,
phil.el@wanadoo.fr, schwab@suse.de, thomas.schlichter@web.de
Subject: Re: [2.6.4-rc2] bogus semicolon behind if()
Date: Sat, 20 Mar 2004 18:04:55 +0100 (MET) [thread overview]
Message-ID: <200403201704.i2KH4tTS008272@harpo.it.uu.se> (raw)
On Thu, 18 Mar 2004 01:52:36 -0800, Andrew Morton wrote:
>Mikael Pettersson <mikpe@csd.uu.se> wrote:
>>
>> Maciej W. Rozycki writes:
>> > On Wed, 17 Mar 2004, Andrew Morton wrote:
>> >
>> > > I still have a couple of NMI patches in -mm:
>> > >
>> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.5-rc1/2.6.5-rc1-mm1/broken-out/nmi_watchdog-local-apic-fix.patch
>> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.5-rc1/2.6.5-rc1-mm1/broken-out/nmi-1-hz.patch
>> > >
>> > > What should we do with these?
>> >
>> > I think we should ask Mikael Pettersson as he is the local APIC watchdog
>> > expert. Mikael?
>>
>> Will do. Is there a problem with them, or do you just want them
>> reviewed for merging into 2.6.5-rc?
>>
>
>They seem to work OK - I did a batch of testing with various setups. But a
>retest wouldn't hurt.
>
>We mainly need a review and general finish-it-off-and-bless-it please.
'nmi_watchdog-local-apic-fix.patch' looks Ok, although I
would prefer if it didn't put a 'static' on nmi_perfctr_msr:
the perfctr driver needs access to it.
I'm not happy with 'nmi-1-hz.patch'. The real problem is that
SMP with nmi_watchdog=2 initialises the lapic NMI watchdog but
doesn't check it and therefore doesn't reduce nmi_hz.
This is an SMP bug, but instead of fixing it the patch removes
the check from UP and changes nmi.c to compensate.
This would be Ok if check_nmi_watchdog() with nmi_watchdog=2
was redundant, but I don't believe it is. It has exposed bugs
and unexpected hardware changes before, and so should remain.
I propose the patch below instead. It changes smpboot.c to do a
check_nmi_watchdog() at the appropriate place, which fixes the
high NMI frequency problem w/o changing anything else.
I've verified that it solves the problem on my MP-capable UP box.
/Mikael
diff -ruN linux-2.6.5-rc2/arch/i386/kernel/smpboot.c linux-2.6.5-rc2.smpboot-lapic-watchdog-fix/arch/i386/kernel/smpboot.c
--- linux-2.6.5-rc2/arch/i386/kernel/smpboot.c 2004-03-11 14:01:25.000000000 +0100
+++ linux-2.6.5-rc2.smpboot-lapic-watchdog-fix/arch/i386/kernel/smpboot.c 2004-03-20 17:21:30.113862000 +0100
@@ -1107,6 +1107,9 @@
}
}
+ if (nmi_watchdog == NMI_LOCAL_APIC)
+ check_nmi_watchdog();
+
smpboot_setup_io_apic();
setup_boot_APIC_clock();
next reply other threads:[~2004-03-20 17:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-20 17:04 Mikael Pettersson [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-03-08 23:14 Thomas Schlichter
2004-03-08 23:43 ` Andreas Schwab
2004-03-08 23:56 ` Thomas Schlichter
2004-03-09 0:29 ` Andrew Morton
2004-03-09 7:01 ` Philippe Elie
2004-03-09 11:08 ` Thomas Schlichter
2004-03-10 6:08 ` Philippe Elie
2004-03-10 16:20 ` Zwane Mwaikambo
2004-03-17 17:20 ` Maciej W. Rozycki
2004-03-17 16:51 ` Maciej W. Rozycki
2004-03-17 18:25 ` Andrew Morton
2004-03-17 18:50 ` Maciej W. Rozycki
2004-03-18 9:46 ` Mikael Pettersson
2004-03-18 9:52 ` Andrew Morton
2004-03-21 3:51 ` Zwane Mwaikambo
2004-03-21 3:55 ` Zwane Mwaikambo
2004-03-19 19:01 ` Thomas Schlichter
2004-03-19 20:30 ` Maciej W. Rozycki
2004-03-19 23:13 ` Thomas Schlichter
2004-03-09 0:33 ` Andrew Morton
2004-03-09 11:09 ` Thomas Schlichter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403201704.i2KH4tTS008272@harpo.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=phil.el@wanadoo.fr \
--cc=schwab@suse.de \
--cc=thomas.schlichter@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®