From: viro@parcelfarce.linux.theplanet.co.uk
To: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bind Mount Extensions 0.04.1 3/5
Date: Thu, 18 Mar 2004 12:26:45 +0000 [thread overview]
Message-ID: <20040318122645.GJ31500@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040315075814.GE31818@MAIL.13thfloor.at>
On Mon, Mar 15, 2004 at 08:58:14AM +0100, Herbert Poetzl wrote:
> -extern int vfs_permission(struct inode *, int);
> +extern int vfs_permission(struct inode *, int, struct nameidata *);
Vetoed, along with IS_RDONLY() prototype change.
Note that you are doing exactly the opposite of the changes we'll need
to deal with remount races.
What we need is to push readonly checks _up_ - into callers of fs methods.
vfs_permission() is default ->permission() - no more, no less. Neither
it nor other instances have any business touching "this vfsmount is readonly"
logics - it's not something where fs can override stuff; it's "admin said
no r/w access here".
IOW, the check for r/w access to file/directory/symlink on a r/o mount should
be moved into the callers (very few of them) of ->permission() and away from
the methods themselves.
next prev parent reply other threads:[~2004-03-18 12:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 3:55 [PATCH] Bind Mount Extensions 0.04 (linux-2.6.4) Herbert Poetzl
2004-03-15 4:14 ` Andrew Morton
2004-03-15 4:25 ` Herbert Poetzl
2004-03-15 4:34 ` Andrew Morton
2004-03-15 7:55 ` Herbert Poetzl
2004-03-15 7:56 ` [PATCH] Bind Mount Extensions 0.04.1 1/5 Herbert Poetzl
2004-03-15 7:57 ` [PATCH] Bind Mount Extensions 0.04.1 2/5 Herbert Poetzl
2004-03-18 12:16 ` viro
2004-03-19 1:57 ` Herbert Poetzl
2004-04-02 1:23 ` Herbert Poetzl
2004-03-15 7:58 ` [PATCH] Bind Mount Extensions 0.04.1 3/5 Herbert Poetzl
2004-03-15 22:10 ` Andrew Morton
2004-03-15 23:04 ` Herbert Poetzl
2004-03-15 23:31 ` Andrew Morton
2004-03-16 6:30 ` Herbert Poetzl
2004-03-18 12:26 ` viro [this message]
2004-03-19 2:52 ` Herbert Poetzl
2004-03-19 11:11 ` viro
2004-03-19 13:40 ` Herbert Poetzl
2004-03-19 14:52 ` viro
2004-03-15 7:58 ` [PATCH] Bind Mount Extensions 0.04.1 4/5 Herbert Poetzl
2004-03-15 7:59 ` [PATCH] Bind Mount Extensions 0.04.1 5/5 Herbert Poetzl
2004-03-15 13:25 ` [PATCH] Bind Mount Extensions 0.04 (linux-2.6.4) Marc-Christian Petersen
2004-03-15 18:25 ` Dariush Pietrzak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040318122645.GJ31500@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®