From: Herbert Poetzl <herbert@13thfloor.at>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bind Mount Extensions 0.04.1 2/5
Date: Fri, 2 Apr 2004 03:23:33 +0200 [thread overview]
Message-ID: <20040402012333.GB13851@MAIL.13thfloor.at> (raw)
In-Reply-To: <20040318121650.GI31500@parcelfarce.linux.theplanet.co.uk>
On Thu, Mar 18, 2004 at 12:16:50PM +0000, viro@parcelfarce.linux.theplanet.co.uk wrote:
> On Mon, Mar 15, 2004 at 08:57:23AM +0100, Herbert Poetzl wrote:
> > -void update_atime(struct inode *inode)
> > +void update_atime(struct inode *inode, struct vfsmount *mnt)
>
> _Hell_, no. Proper solution is to move the callers upstream instead
> of propagating vfsmounts downstream. That, BTW, was the main reason
> for readdir() patch.
# 04/03/18 viro@parcelfarce.linux.theplanet.co.uk 1.1795.6.4
# [PATCH] add touch_atime() helper
#
# Preparation for per-mountpoint noatime, nodiratime and later -
# per-mountpoint r/o. Depends on file_accessed() patch, should go after
# it.
#
# New helper - touch_atime(mnt, dentry). It's a wrapper for
# update_atime() and that's where all future per-mountpoint checks will
# go.
static inline void touch_atime(struct vfsmount *mnt, struct dentry *dentry)
{
/* per-mountpoint checks will go here */
update_atime(dentry->d_inode);
}
Hum, so that is what you call 'moving the callers upstream'
instead of 'propagating vfsmounts downstream' ...
best,
Herbert
> BTW, update_atime() is exported. And it's 2.6 now...
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2004-04-02 1:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 3:55 [PATCH] Bind Mount Extensions 0.04 (linux-2.6.4) Herbert Poetzl
2004-03-15 4:14 ` Andrew Morton
2004-03-15 4:25 ` Herbert Poetzl
2004-03-15 4:34 ` Andrew Morton
2004-03-15 7:55 ` Herbert Poetzl
2004-03-15 7:56 ` [PATCH] Bind Mount Extensions 0.04.1 1/5 Herbert Poetzl
2004-03-15 7:57 ` [PATCH] Bind Mount Extensions 0.04.1 2/5 Herbert Poetzl
2004-03-18 12:16 ` viro
2004-03-19 1:57 ` Herbert Poetzl
2004-04-02 1:23 ` Herbert Poetzl [this message]
2004-03-15 7:58 ` [PATCH] Bind Mount Extensions 0.04.1 3/5 Herbert Poetzl
2004-03-15 22:10 ` Andrew Morton
2004-03-15 23:04 ` Herbert Poetzl
2004-03-15 23:31 ` Andrew Morton
2004-03-16 6:30 ` Herbert Poetzl
2004-03-18 12:26 ` viro
2004-03-19 2:52 ` Herbert Poetzl
2004-03-19 11:11 ` viro
2004-03-19 13:40 ` Herbert Poetzl
2004-03-19 14:52 ` viro
2004-03-15 7:58 ` [PATCH] Bind Mount Extensions 0.04.1 4/5 Herbert Poetzl
2004-03-15 7:59 ` [PATCH] Bind Mount Extensions 0.04.1 5/5 Herbert Poetzl
2004-03-15 13:25 ` [PATCH] Bind Mount Extensions 0.04 (linux-2.6.4) Marc-Christian Petersen
2004-03-15 18:25 ` Dariush Pietrzak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040402012333.GB13851@MAIL.13thfloor.at \
--to=herbert@13thfloor.at \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®