From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Tom Rini <trini@kernel.crashing.org>
Subject: [patch] minor fix to kgdboe configuration logic
Date: Sat, 20 Mar 2004 18:46:19 -0600 [thread overview]
Message-ID: <20040321004618.GV11010@waste.org> (raw)
This seems to have gotten dropped. Without it, kgdboe can get into a
half-configured state.
kgdboe - fix configuration of MAC address
tiny-mpm/drivers/net/kgdb_eth.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff -puN drivers/net/kgdb_eth.c~kgdboe-mac-init drivers/net/kgdb_eth.c
--- tiny/drivers/net/kgdb_eth.c~kgdboe-mac-init 2004-03-16 12:03:11.000000000 -0600
+++ tiny-mpm/drivers/net/kgdb_eth.c 2004-03-16 12:03:11.000000000 -0600
@@ -46,6 +46,7 @@ static struct netpoll np = {
.remote_port = 6442,
.remote_mac = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff},
};
+static int configured;
int eth_getDebugChar(void)
{
@@ -101,9 +102,9 @@ static void rx_hook(struct netpoll *np,
}
}
-static int option_setup(char *opt)
+static void option_setup(char *opt)
{
- return netpoll_parse_options(&np, opt);
+ configured = !netpoll_parse_options(&np, opt);
}
__setup("kgdboe=", option_setup);
@@ -119,7 +120,7 @@ static int init_kgdboe(void)
set_debug_traps();
- if(!np.remote_ip || netpoll_setup(&np))
+ if(!configured || netpoll_setup(&np))
return 1;
kgdboe = 1;
_
--
Matt Mackall : http://www.selenic.com : Linux development and consulting
next reply other threads:[~2004-03-21 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-21 0:46 Matt Mackall [this message]
2004-03-22 14:47 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040321004618.GV11010@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome