[patch] minor fix to kgdboe configuration logic

[patch] minor fix to kgdboe configuration logic

[Matt Mackall]

This seems to have gotten dropped. Without it, kgdboe can get into a
half-configured state.

kgdboe - fix configuration of MAC address


 tiny-mpm/drivers/net/kgdb_eth.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff -puN drivers/net/kgdb_eth.c~kgdboe-mac-init drivers/net/kgdb_eth.c
--- tiny/drivers/net/kgdb_eth.c~kgdboe-mac-init	2004-03-16 12:03:11.000000000 -0600
+++ tiny-mpm/drivers/net/kgdb_eth.c	2004-03-16 12:03:11.000000000 -0600
@@ -46,6 +46,7 @@ static struct netpoll np = {
 	.remote_port = 6442,
 	.remote_mac = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff},
 };
+static int configured;
 
 int eth_getDebugChar(void)
 {
@@ -101,9 +102,9 @@ static void rx_hook(struct netpoll *np, 
 	}
 }
 
-static int option_setup(char *opt)
+static void option_setup(char *opt)
 {
-	return netpoll_parse_options(&np, opt);
+        configured = !netpoll_parse_options(&np, opt);
 }
 
 __setup("kgdboe=", option_setup);
@@ -119,7 +120,7 @@ static int init_kgdboe(void)
 
 	set_debug_traps();
 
-	if(!np.remote_ip || netpoll_setup(&np))
+	if(!configured || netpoll_setup(&np))
 		return 1;
 
 	kgdboe = 1;

_

-- 
Matt Mackall : http://www.selenic.com : Linux development and consulting

Re: [patch] minor fix to kgdboe configuration logic

[Tom Rini]

On Sat, Mar 20, 2004 at 06:46:19PM -0600, Matt Mackall wrote:

> This seems to have gotten dropped. Without it, kgdboe can get into a
> half-configured state.
> 
> kgdboe - fix configuration of MAC address
> 
> 
>  tiny-mpm/drivers/net/kgdb_eth.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)

Thanks, applied.

-- 
Tom Rini
http://gate.crashing.org/~trini/