From: Adrian Bunk <bunk@fs.tum.de>
To: rmk@arm.linux.org.uk, David Hinds <dhinds@sonic.net>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] fix two PCMCIA warnings
Date: Sun, 21 Mar 2004 15:09:30 +0100 [thread overview]
Message-ID: <20040321140930.GA19464@fs.tum.de> (raw)
The
Add, fix, update PCMCIA debugging.
patch in 2.6.5-rc introduced the following compile warnings with
CONFIG_PCMCIA_DEBUG enabled:
<-- snip -->
...
CC drivers/pcmcia/i82365.o
drivers/pcmcia/i82365.c:71: warning: `version' defined but not used
...
CC drivers/pcmcia/tcic.o
drivers/pcmcia/tcic.c:64: warning: `version' defined but not used
...
<-- snip -->
Since the version strings are unused and seem to be quite outdated, I
propose the patch below to remove them.
I've tested both the modular and the non-modular compilation with this
patch applied.
Please apply
Adrian
--- linux-2.6.5-rc2-mm1-full/drivers/pcmcia/i82365.c.old 2004-03-21 15:00:31.000000000 +0100
+++ linux-2.6.5-rc2-mm1-full/drivers/pcmcia/i82365.c 2004-03-21 15:00:45.000000000 +0100
@@ -68,9 +68,6 @@
#include "o2micro.h"
#ifdef DEBUG
-static const char *version =
-"i82365.c 1.265 1999/11/10 18:36:21 (David Hinds)";
-
static int pc_debug;
module_param(pc_debug, int, 0644);
--- linux-2.6.5-rc2-mm1-full/drivers/pcmcia/tcic.c.old 2004-03-21 15:01:24.000000000 +0100
+++ linux-2.6.5-rc2-mm1-full/drivers/pcmcia/tcic.c 2004-03-21 15:01:34.000000000 +0100
@@ -61,8 +61,6 @@
module_param(pc_debug, int, 0644);
MODULE_PARM(pc_debug, "i");
-static const char *version =
-"tcic.c 1.111 2000/02/15 04:13:12 (David Hinds)";
#define debug(lvl, fmt, arg...) do { \
if (pc_debug > (lvl)) \
reply other threads:[~2004-03-21 14:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040321140930.GA19464@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=dhinds@sonic.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®