mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [2.6 patch] fix two PCMCIA warnings
@ 2004-03-21 14:09 Adrian Bunk
  0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2004-03-21 14:09 UTC (permalink / raw)
  To: rmk, David Hinds; +Cc: linux-kernel

The

  Add, fix, update PCMCIA debugging.

patch in 2.6.5-rc introduced the following compile warnings with 
CONFIG_PCMCIA_DEBUG enabled:


<--  snip  -->

...
  CC      drivers/pcmcia/i82365.o
drivers/pcmcia/i82365.c:71: warning: `version' defined but not used
...
  CC      drivers/pcmcia/tcic.o
drivers/pcmcia/tcic.c:64: warning: `version' defined but not used
...

<--  snip  -->


Since the version strings are unused and seem to be quite outdated, I 
propose the patch below to remove them.

I've tested both the modular and the non-modular compilation with this 
patch applied.

Please apply
Adrian


--- linux-2.6.5-rc2-mm1-full/drivers/pcmcia/i82365.c.old	2004-03-21 15:00:31.000000000 +0100
+++ linux-2.6.5-rc2-mm1-full/drivers/pcmcia/i82365.c	2004-03-21 15:00:45.000000000 +0100
@@ -68,9 +68,6 @@
 #include "o2micro.h"
 
 #ifdef DEBUG
-static const char *version =
-"i82365.c 1.265 1999/11/10 18:36:21 (David Hinds)";
-
 static int pc_debug;
 
 module_param(pc_debug, int, 0644);
--- linux-2.6.5-rc2-mm1-full/drivers/pcmcia/tcic.c.old	2004-03-21 15:01:24.000000000 +0100
+++ linux-2.6.5-rc2-mm1-full/drivers/pcmcia/tcic.c	2004-03-21 15:01:34.000000000 +0100
@@ -61,8 +61,6 @@
 
 module_param(pc_debug, int, 0644);
 MODULE_PARM(pc_debug, "i");
-static const char *version =
-"tcic.c 1.111 2000/02/15 04:13:12 (David Hinds)";
 
 #define debug(lvl, fmt, arg...) do {				\
 	if (pc_debug > (lvl))					\

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-03-21 14:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-21 14:09 [2.6 patch] fix two PCMCIA warnings Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®