mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Makefile patch to create KBUILD_OUPUT if it doesn't exist
@ 2004-03-31 22:47 Brian Jackson
  2004-04-01  4:58 ` Sam Ravnborg
  0 siblings, 1 reply; 2+ messages in thread
From: Brian Jackson @ 2004-03-31 22:47 UTC (permalink / raw)
  To: linux-kernel; +Cc: kai, sam

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

It was probably intentional to not have the Makefile automagically create 
KBUILD_OUPUT if it doesn't exist, but just in case, here's a patch which 
makes it do just that. I'd appreciate feedback either way just so I know if 
it's actually getting looked at or if it got lost somewhere along the way.

- --Brian Jackson

- --- Makefile.orig	2004-03-31 16:21:48.254691909 -0600
+++ Makefile	2004-03-31 16:34:27.507098249 -0600
@@ -88,10 +88,10 @@
 ifneq ($(KBUILD_OUTPUT),)
 # Invoke a second make in the output directory, passing relevant variables
 # check that the output directory actually exists
+$(if $(wildcard $(KBUILD_OUTPUT)),, \
+     $(shell mkdir -p ${KBUILD_OUTPUT}))
 saved-output := $(KBUILD_OUTPUT)
 KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT) && /bin/pwd)
- -$(if $(wildcard $(KBUILD_OUTPUT)),, \
- -     $(error output directory "$(saved-output)" does not exist))
 
 .PHONY: $(MAKECMDGOALS)
 

- -- 
http://www.brianandsara.net
For Sale : http://www.brianandsara.net/temp/forsale.php
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAa0qH+cPN+Z7qK9cRAiB9AJ0dtkq92cgYTailSvEPBS2Z/iez9wCg0CA2
GBdCdX7RPUhe9EXdXn7Y6Yg=
=+vf2
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Makefile patch to create KBUILD_OUPUT if it doesn't exist
  2004-03-31 22:47 [PATCH] Makefile patch to create KBUILD_OUPUT if it doesn't exist Brian Jackson
@ 2004-04-01  4:58 ` Sam Ravnborg
  0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2004-04-01  4:58 UTC (permalink / raw)
  To: Brian Jackson; +Cc: linux-kernel, kai, sam

On Wed, Mar 31, 2004 at 04:47:35PM -0600, Brian Jackson wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> It was probably intentional to not have the Makefile automagically create 
> KBUILD_OUPUT if it doesn't exist, but just in case, here's a patch which 
> makes it do just that.

It was not done so typing errors do not start creating a lot of directories.
but it is also tiresome to type:
mkdir ~/b
make O=~/b ...

Could you make kbuild print out the created directory in kbuild format:
CRDIR   dir/which/is/created

	Sam


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-04-01  4:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-31 22:47 [PATCH] Makefile patch to create KBUILD_OUPUT if it doesn't exist Brian Jackson
2004-04-01  4:58 ` Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®