From: viro@parcelfarce.linux.theplanet.co.uk
To: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch] BME, noatime and nodiratime
Date: Wed, 7 Apr 2004 00:11:36 +0100 [thread overview]
Message-ID: <20040406231136.GN31500@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040406204843.GL31500@parcelfarce.linux.theplanet.co.uk>
On Tue, Apr 06, 2004 at 09:48:44PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> noatime/nodiratime: OK, but we still have direct modifications of i_atime
> that need to be taken care of.
Particulary interesting one is in tty_io.c. There we
1) unconditionally touch i_atime on read()
2) do not touch it on write()
3) never mark the inode dirty.
Note that the last one means that doing stat() in a loop will sometimes
give atime going backwards. We also completely ignore noatime here.
There are similar places in some other char drivers. Obvious step would
be to have them do file_accessed() instead; however, I'd really like to
hear the rationale for existing behaviour. Comments?
next prev parent reply other threads:[~2004-04-06 23:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-06 14:55 Herbert Poetzl
2004-04-06 20:48 ` viro
2004-04-06 23:11 ` viro [this message]
2004-04-06 23:35 ` Russell King
2004-04-07 6:44 ` viro
2004-04-14 15:14 ` Linus Torvalds
2004-04-14 16:26 ` viro
2004-04-07 6:46 ` Herbert Poetzl
2004-04-07 8:47 ` viro
2004-04-07 10:19 ` Herbert Poetzl
2004-04-07 12:46 ` viro
2004-04-07 14:24 ` Herbert Poetzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040406231136.GN31500@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®