From: viro@parcelfarce.linux.theplanet.co.uk
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [Patch] BME, noatime and nodiratime
Date: Wed, 14 Apr 2004 17:26:37 +0100 [thread overview]
Message-ID: <20040414162637.GF31500@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0404140803040.12398@ppc970.osdl.org>
On Wed, Apr 14, 2004 at 08:14:18AM -0700, Linus Torvalds wrote:
> Ignoring noatime is potentially the only one we should look at, but since
> tty's really _are_ "noatime" as far as the filesystem is concerned, I
> think it makes sense in the situation we are in anyway. The real reason
> for "noatime" is to avoid unnecessary filesystem activity, not that we
> necessarily want a constant atime.
Another thing we are ignoring is r/o. Oh, well - the same arguments apply.
> > There are similar places in some other char drivers. Obvious step would
> > be to have them do file_accessed() instead; however, I'd really like to
> > hear the rationale for existing behaviour. Comments?
>
> I don't know about other char drivers, those may well be wrong. But for
> tty's in particular, idle time calculations really do pretty much require
> the behaviour (apart from #3 - and #3 is, I think, effectively required by
> not wanting to touch the disk on keyboard accesses).
AFAICS, they simply copy what tty_io.c does. Out of these guys busmouse.c
might have a similar excuse; qtronix.c and sonypi.c AFAICS have no reason
to touch atime at all. No idea what should usb/core/devio.c do...
Anyway, I'm going down right now; expect a patchbomb tonight after I get
some sleep...
next prev parent reply other threads:[~2004-04-14 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-06 14:55 Herbert Poetzl
2004-04-06 20:48 ` viro
2004-04-06 23:11 ` viro
2004-04-06 23:35 ` Russell King
2004-04-07 6:44 ` viro
2004-04-14 15:14 ` Linus Torvalds
2004-04-14 16:26 ` viro [this message]
2004-04-07 6:46 ` Herbert Poetzl
2004-04-07 8:47 ` viro
2004-04-07 10:19 ` Herbert Poetzl
2004-04-07 12:46 ` viro
2004-04-07 14:24 ` Herbert Poetzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040414162637.GF31500@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®