From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/char/KConfig: Remove "BROKEN_ON_SMP" tag on CYCLADES entry
Date: Fri, 9 Apr 2004 18:21:23 -0300 [thread overview]
Message-ID: <20040409212123.GB18694@logos.cnet> (raw)
Hi Andrew,
The cyclades.c driver was marked BROKEN_ON_SMP during early 2.6. It was fixed later
on but the tag was left in Kconfig.
The driver is not very smart wrt SMP locking, it can be improved. There is only
one spinlock percard which guarantees command block ordering and protects different
shared data, which can be held for long periods.
_But_ the locking works reliably, so remove the BROKEN_ON_SMP tag.
Please apply.
--- linux-2.6.5-mc2.orig/drivers/char/Kconfig 2004-04-09 17:49:22.703814096 -0300
+++ linux-2.6.5-mc2/drivers/char/Kconfig 2004-04-08 18:04:21.000000000 -0300
@@ -110,7 +110,7 @@
config CYCLADES
tristate "Cyclades async mux support"
- depends on SERIAL_NONSTANDARD && BROKEN_ON_SMP
+ depends on SERIAL_NONSTANDARD
---help---
This is a driver for a card that gives you many serial ports. You
would need something like this to connect more than two modems to
reply other threads:[~2004-04-09 21:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040409212123.GB18694@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®