* [PATCH] drivers/char/KConfig: Remove "BROKEN_ON_SMP" tag on CYCLADES entry
@ 2004-04-09 21:21 Marcelo Tosatti
0 siblings, 0 replies; only message in thread
From: Marcelo Tosatti @ 2004-04-09 21:21 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
Hi Andrew,
The cyclades.c driver was marked BROKEN_ON_SMP during early 2.6. It was fixed later
on but the tag was left in Kconfig.
The driver is not very smart wrt SMP locking, it can be improved. There is only
one spinlock percard which guarantees command block ordering and protects different
shared data, which can be held for long periods.
_But_ the locking works reliably, so remove the BROKEN_ON_SMP tag.
Please apply.
--- linux-2.6.5-mc2.orig/drivers/char/Kconfig 2004-04-09 17:49:22.703814096 -0300
+++ linux-2.6.5-mc2/drivers/char/Kconfig 2004-04-08 18:04:21.000000000 -0300
@@ -110,7 +110,7 @@
config CYCLADES
tristate "Cyclades async mux support"
- depends on SERIAL_NONSTANDARD && BROKEN_ON_SMP
+ depends on SERIAL_NONSTANDARD
---help---
This is a driver for a card that gives you many serial ports. You
would need something like this to connect more than two modems to
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-04-09 21:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-04-09 21:21 [PATCH] drivers/char/KConfig: Remove "BROKEN_ON_SMP" tag on CYCLADES entry Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®