mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kevin Corry <kevcorry@us.ibm.com>
To: LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: [PATCH] Device-Mapper 7/9
Date: Mon, 12 Apr 2004 09:19:07 -0500	[thread overview]
Message-ID: <200404120919.07648.kevcorry@us.ibm.com> (raw)
In-Reply-To: <200404120912.45870.kevcorry@us.ibm.com>

Clarify the comment regarding the "next" field in struct dm_target_spec. The
"next" field has different behavior if you're performing a DM_TABLE_STATUS
command than it does if you're performing a DM_TABLE_LOAD command.

See populate_table() and retrieve_status() in drivers/md/dm-ioctl.c for more
details on how this field is used.

--- diff/include/linux/dm-ioctl.h	2004-04-09 09:41:45.000000000 -0500
+++ source/include/linux/dm-ioctl.h	2004-04-09 09:42:36.000000000 -0500
@@ -129,8 +129,14 @@
 	int32_t status;		/* used when reading from kernel only */
 
 	/*
-	 * Offset in bytes (from the start of this struct) to
-	 * next target_spec.
+	 * Location of the next dm_target_spec.
+	 * - When specifying targets on a DM_TABLE_LOAD command, this value is
+	 *   the number of bytes from the start of the "current" dm_target_spec
+	 *   to the start of the "next" dm_target_spec.
+	 * - When retrieving targets on a DM_TABLE_STATUS command, this value
+	 *   is the number of bytes from the start of the first dm_target_spec
+	 *   (that follows the dm_ioctl struct) to the start of the "next"
+	 *   dm_target_spec.
 	 */
 	uint32_t next;
 

  parent reply	other threads:[~2004-04-12 14:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-12 14:12 [PATCH] Device-Mapper 0/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 1/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 2/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 3/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 4/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 5/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 6/9 Kevin Corry
2004-04-12 14:19 ` Kevin Corry [this message]
2004-04-12 14:19 ` [PATCH] Device-Mapper 8/9 Kevin Corry
2004-04-12 14:19 ` [PATCH] Device-Mapper 9/9 Kevin Corry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200404120919.07648.kevcorry@us.ibm.com \
    --to=kevcorry@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®