From: Kevin Corry <kevcorry@us.ibm.com>
To: LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: [PATCH] Device-Mapper 8/9
Date: Mon, 12 Apr 2004 09:19:15 -0500 [thread overview]
Message-ID: <200404120919.15378.kevcorry@us.ibm.com> (raw)
In-Reply-To: <200404120912.45870.kevcorry@us.ibm.com>
dm-ioctl.c::retrieve_status(): Prevent overrunning the ioctl buffer by making
sure we don't call the target status routine with a buffer size limit of zero.
[Kevin Corry, Alasdair Kergon]
--- diff/drivers/md/dm-ioctl.c 2004-04-09 09:42:29.000000000 -0500
+++ source/drivers/md/dm-ioctl.c 2004-04-09 09:42:44.000000000 -0500
@@ -800,7 +800,7 @@
struct dm_target *ti = dm_table_get_target(table, i);
remaining = len - (outptr - outbuf);
- if (remaining < sizeof(struct dm_target_spec)) {
+ if (remaining <= sizeof(struct dm_target_spec)) {
param->flags |= DM_BUFFER_FULL_FLAG;
break;
}
@@ -815,6 +815,10 @@
outptr += sizeof(struct dm_target_spec);
remaining = len - (outptr - outbuf);
+ if (remaining <= 0) {
+ param->flags |= DM_BUFFER_FULL_FLAG;
+ break;
+ }
/* Get the status/table string from the target driver */
if (ti->type->status) {
next prev parent reply other threads:[~2004-04-12 14:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-12 14:12 [PATCH] Device-Mapper 0/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 1/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 2/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 3/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 4/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 5/9 Kevin Corry
2004-04-12 14:18 ` [PATCH] Device-Mapper 6/9 Kevin Corry
2004-04-12 14:19 ` [PATCH] Device-Mapper 7/9 Kevin Corry
2004-04-12 14:19 ` Kevin Corry [this message]
2004-04-12 14:19 ` [PATCH] Device-Mapper 9/9 Kevin Corry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404120919.15378.kevcorry@us.ibm.com \
--to=kevcorry@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®