From: Andrew Morton <akpm@osdl.org>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: vrajesh@umich.edu, hugh@veritas.com, andrea@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] anobjrmap 9 priority mjb tree
Date: Mon, 12 Apr 2004 14:12:44 -0700 [thread overview]
Message-ID: <20040412141244.5e225cdf.akpm@osdl.org> (raw)
In-Reply-To: <69200000.1081804458@flay>
"Martin J. Bligh" <mbligh@aracnet.com> wrote:
>
> Turns out he'd turned the
> locking in find_get_page from "spin_lock(&mapping->page_lock)" into
> "spin_lock_irq(&mapping->tree_lock)",
That's from the use-radix-tree-walks-for-writeback code.
Use oprofile - it's NMI-based.
> and I'm using readprofile, which
> doesn't profile with irqs off, so it's not really disappeared, just hidden.
> Not sure which sub-patch that comes from, and it turned out to be a bit of
> a dead end, but whilst I'm there, I thought I'd point out this was contended,
> and show the diffprofile with and without spinline for aa5:
>
> 22210 246777.8% find_trylock_page
> 2538 36.4% atomic_dec_and_lock
profiler brokenness, surely. Almost nothing calls find_trylock_page(),
unless Andrea has done something peculiar. Use oprofile.
next prev parent reply other threads:[~2004-04-12 21:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-04 12:33 Hugh Dickins
2004-04-09 20:39 ` Martin J. Bligh
2004-04-09 21:31 ` Rajesh Venkatasubramanian
2004-04-09 21:40 ` Martin J. Bligh
2004-04-09 23:17 ` Rajesh Venkatasubramanian
2004-04-09 21:51 ` Hugh Dickins
2004-04-09 22:01 ` Martin J. Bligh
2004-04-09 22:56 ` Martin J. Bligh
2004-04-11 16:09 ` Hugh Dickins
2004-04-11 17:28 ` Martin J. Bligh
2004-04-12 4:32 ` Rajesh Venkatasubramanian
2004-04-12 5:24 ` Martin J. Bligh
2004-04-12 15:46 ` Martin J. Bligh
2004-04-12 18:43 ` Hugh Dickins
2004-04-12 18:58 ` Rajesh Venkatasubramanian
2004-04-12 19:01 ` Martin J. Bligh
2004-04-12 19:10 ` Hugh Dickins
2004-04-12 19:38 ` Rajesh Venkatasubramanian
2004-04-12 21:14 ` Martin J. Bligh
2004-04-12 21:12 ` Andrew Morton [this message]
2004-04-12 21:43 ` Martin J. Bligh
2004-04-14 20:18 ` Rajesh Venkatasubramanian
2004-04-15 0:05 ` Andrea Arcangeli
2004-04-15 0:22 ` Martin J. Bligh
2004-04-15 3:40 ` Rajesh Venkatasubramanian
2004-04-15 6:23 ` Martin J. Bligh
2004-04-15 10:26 ` Hugh Dickins
2004-04-15 12:52 ` Andrea Arcangeli
2004-04-15 15:40 ` Martin J. Bligh
2004-04-15 16:55 ` Hugh Dickins
2004-04-15 17:14 ` Martin J. Bligh
2004-04-15 17:50 ` Hugh Dickins
2004-04-15 18:42 ` Dave McCracken
[not found] ` <192710000.1082052992@flay>
2004-04-15 18:47 ` Rajesh Venkatasubramanian
2004-04-15 22:40 ` Andrea Arcangeli
2004-04-15 22:33 ` Andrea Arcangeli
2004-04-15 13:00 ` Andrea Arcangeli
2004-04-15 14:41 ` Rajesh Venkatasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040412141244.5e225cdf.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=vrajesh@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®