mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: jgarzik@pobox.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] conditionalize some boring buffer_head checks
Date: Wed, 14 Apr 2004 01:02:40 -0700	[thread overview]
Message-ID: <20040414010240.0e9f4115.akpm@osdl.org> (raw)
In-Reply-To: <20040414005832.083de325.akpm@osdl.org>

Andrew Morton <akpm@osdl.org> wrote:
>
>  buffer_error() was always supposed to be temporary.  Once per month someone
>  reports the one in __find_get_block_slow(), but that's all.  The only
>  reason for keeping it around is as a debug aid to filesystem developers.
> 
>  We could make it a no-op if !CONFIG_BUFFER_DEBUG.

But even if we do that, the compiler cannot optimise away things like:

	if (atomic_read(&bh->b_count) == 0 &&
			!PageLocked(bh->b_page) &&
			!PageWriteback(bh->b_page))
		do {} while (0);

so if it offends you, go kill the thing outright.


  reply	other threads:[~2004-04-14  8:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-14  7:43 Jeff Garzik
2004-04-14  7:58 ` Andrew Morton
2004-04-14  8:02   ` Andrew Morton [this message]
2004-04-14  8:10     ` Jeff Garzik
2004-04-14  8:16       ` Andrew Morton
2004-04-14  8:45         ` Jeff Garzik
2004-04-14  9:10         ` Jeff Garzik
2004-04-14 21:25           ` Matt Mackall
2004-04-14 21:27             ` Randy.Dunlap
2004-04-14 21:37               ` Matt Mackall
2004-04-14 21:33             ` Jeff Garzik
2004-04-14 21:49               ` Matt Mackall
2004-04-15  6:12               ` Zwane Mwaikambo
2004-04-15 20:52             ` PATCH] Kconfig.debug family Randy.Dunlap
2004-04-15 21:36               ` Sam Ravnborg
2004-04-15 21:36               ` Marc-Christian Petersen
2004-04-15 21:41                 ` Randy.Dunlap
2004-04-14  8:27       ` [PATCH] conditionalize some boring buffer_head checks Tim Hockin
2004-04-14  8:48         ` Jeff Garzik
2004-04-14 13:31           ` Chris Friesen
2004-04-14 15:05             ` Randy.Dunlap
2004-04-14  8:29 ` Jens Axboe
2004-04-14  8:42   ` Jeff Garzik
2004-04-14  8:47     ` Jens Axboe
     [not found] <1KNjN-gZ-9@gated-at.bofh.it>
     [not found] ` <1KNDc-Bv-9@gated-at.bofh.it>
     [not found]   ` <1KNDg-Bv-25@gated-at.bofh.it>
     [not found]     ` <1KNMQ-Hs-15@gated-at.bofh.it>
     [not found]       ` <1KNWA-OH-25@gated-at.bofh.it>
2004-04-14 12:14         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040414010240.0e9f4115.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®