mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2.6.5-mm4] Trivial : emu10k1 definition redundancy
@ 2004-04-14 20:07 Fabian Frederick
  2004-04-14 20:20 ` Chris Wright
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2004-04-14 20:07 UTC (permalink / raw)
  To: lkml

[-- Attachment #1: Type: text/plain, Size: 58 bytes --]

Remove emu10k1_t definition redundancy

Regards,
Fabian



[-- Attachment #2: emu10k11.diff --]
[-- Type: text/x-patch, Size: 1312 bytes --]

diff -Naur orig/include/sound/emu10k1.h edited/include/sound/emu10k1.h
--- orig/include/sound/emu10k1.h	2004-04-04 05:36:52.000000000 +0200
+++ edited/include/sound/emu10k1.h	2004-04-07 11:25:50.000000000 +0200
@@ -1368,4 +1368,6 @@
 #define SNDRV_EMU10K1_IOCTL_SINGLE_STEP	_IOW ('H', 0x83, int)
 #define SNDRV_EMU10K1_IOCTL_DBG_READ	_IOR ('H', 0x84, int)
 
+#define chip_t emu10k1_t
+
 #endif	/* __SOUND_EMU10K1_H */
diff -Naur orig/sound/pci/emu10k1/emufx.c edited/sound/pci/emu10k1/emufx.c
--- orig/sound/pci/emu10k1/emufx.c	2004-04-04 05:37:07.000000000 +0200
+++ edited/sound/pci/emu10k1/emufx.c	2004-04-07 11:26:09.000000000 +0200
@@ -33,8 +33,6 @@
 #include <sound/core.h>
 #include <sound/emu10k1.h>
 
-#define chip_t emu10k1_t
-
 #if 0		/* for testing purposes - digital out -> capture */
 #define EMU10K1_CAPTURE_DIGITAL_OUT
 #endif
diff -Naur orig/sound/pci/emu10k1/emumixer.c edited/sound/pci/emu10k1/emumixer.c
--- orig/sound/pci/emu10k1/emumixer.c	2004-04-04 05:38:11.000000000 +0200
+++ edited/sound/pci/emu10k1/emumixer.c	2004-04-07 11:25:54.000000000 +0200
@@ -32,8 +32,6 @@
 #include <sound/core.h>
 #include <sound/emu10k1.h>
 
-#define chip_t emu10k1_t
-
 static int snd_emu10k1_spdif_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
 {
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2.6.5-mm4] Trivial : emu10k1 definition redundancy
  2004-04-14 20:07 [PATCH 2.6.5-mm4] Trivial : emu10k1 definition redundancy Fabian Frederick
@ 2004-04-14 20:20 ` Chris Wright
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Wright @ 2004-04-14 20:20 UTC (permalink / raw)
  To: Fabian Frederick; +Cc: lkml

* Fabian Frederick (Fabian.Frederick@skynet.be) wrote:
> Remove emu10k1_t definition redundancy

This one's probably fine.  It'd be nice if you could inline the patches
in your mail (making sure whitespaces won't get munged and lines won't
get linewrapped by your mailer).  Makes it easier to view the patch and
reply with comments inlined in the patch.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-04-14 20:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-04-14 20:07 [PATCH 2.6.5-mm4] Trivial : emu10k1 definition redundancy Fabian Frederick
2004-04-14 20:20 ` Chris Wright

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®