From: Andrew Morton <akpm@osdl.org>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: linux-kernel@vger.kernel.org, Max Asbock <masbock@us.ibm.com>
Subject: Re: [PATCH] Kconfig dependancy update for drivers/misc/ibmasm
Date: Tue, 20 Apr 2004 14:34:18 -0700 [thread overview]
Message-ID: <20040420143418.08962d0b.akpm@osdl.org> (raw)
In-Reply-To: <20040420210110.GD3445@bakeyournoodle.com>
Tony Breeds <tony@bakeyournoodle.com> wrote:
>
>
> Hello,
> Some weeks ago I saw this compile error posted to lkml:
>
> ---
> > LD .tmp_vmlinux1
> > drivers/built-in.o(.text+0x435e1): In function `ibmasm_register_uart':
> > : undefined reference to `register_serial'
> > drivers/built-in.o(.text+0x43649): In function `ibmasm_unregister_uart':
> > : undefined reference to `unregister_serial'
> > make: *** [.tmp_vmlinux1] Error 1
> > summer@Dolphin:~/pebble/kernel/linux-2.6.4$
> ---
>
> This was created because ibmasm was set to yes BUT the 8250 was a
> module. I believe the correct (tested) fix is below.
Seems sane to me, but I'm not sure why this wasn't done originally. ie, this:
+#ifdef CONFIG_SERIAL_8250
extern void ibmasm_register_uart(struct service_processor *sp);
extern void ibmasm_unregister_uart(struct service_processor *sp);
+#else
+#define ibmasm_register_uart(sp) do { } while(0)
+#define ibmasm_unregister_uart(sp) do { } while(0)
+#endif
becomes unnecessary with your patch.
Max, any preferences?
> ################################################################################
> --- 2.6.4.clean/drivers/misc/Kconfig 2004-03-11 17:57:23.000000000 +1100
> +++ 2.6.4.noconfig/drivers/misc/Kconfig 2004-03-30 09:32:07.000000000 +1000
> @@ -6,7 +6,7 @@
>
> config IBM_ASM
> tristate "Device driver for IBM RSA service processor"
> - depends on X86
> + depends on X86 && SERIAL_8250
> default n
> ---help---
> This option enables device driver support for in-band access to the
> ################################################################################
>
> Yours Tony
>
> linux.conf.au http://lca2005.linux.org.au/
> Apr 18-23 2005 The Australian Linux Technical Conference!
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
> ----- End forwarded message -----
>
> Yours Tony
>
> linux.conf.au http://lca2005.linux.org.au/
> Apr 18-23 2005 The Australian Linux Technical Conference!
next prev parent reply other threads:[~2004-04-20 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-20 21:01 Tony Breeds
2004-04-20 21:34 ` Andrew Morton [this message]
2004-04-20 21:41 ` Tony Breeds
2004-04-20 22:49 ` Max Asbock
2004-04-20 23:42 ` Andrew Morton
2004-04-21 0:17 ` Max Asbock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040420143418.08962d0b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masbock@us.ibm.com \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®