From: Tony Breeds <tony@bakeyournoodle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Max Asbock <masbock@us.ibm.com>
Subject: Re: [PATCH] Kconfig dependancy update for drivers/misc/ibmasm
Date: Wed, 21 Apr 2004 05:41:25 +0800 [thread overview]
Message-ID: <20040420214125.GF3445@bakeyournoodle.com> (raw)
In-Reply-To: <20040420143418.08962d0b.akpm@osdl.org>
On Tue, Apr 20, 2004 at 02:34:18PM -0700, Andrew Morton wrote:
> Seems sane to me, but I'm not sure why this wasn't done originally. ie, this:
>
> +#ifdef CONFIG_SERIAL_8250
> extern void ibmasm_register_uart(struct service_processor *sp);
> extern void ibmasm_unregister_uart(struct service_processor *sp);
> +#else
> +#define ibmasm_register_uart(sp) do { } while(0)
> +#define ibmasm_unregister_uart(sp) do { } while(0)
> +#endif
>
> becomes unnecessary with your patch.
>
> Max, any preferences?
If I read this correctly the above patch would mean that ibmasm can be
built regardless of the value of SERIAL_8250 BUT my patch means it can
only be built if SERIAL_8250 is also being built (regardless of state).
Can the device operate correctly without the uart? If so then my patch
is bogus.
Yours Tony
linux.conf.au http://lca2005.linux.org.au/
Apr 18-23 2005 The Australian Linux Technical Conference!
next prev parent reply other threads:[~2004-04-20 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-20 21:01 Tony Breeds
2004-04-20 21:34 ` Andrew Morton
2004-04-20 21:41 ` Tony Breeds [this message]
2004-04-20 22:49 ` Max Asbock
2004-04-20 23:42 ` Andrew Morton
2004-04-21 0:17 ` Max Asbock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040420214125.GF3445@bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masbock@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®