Re: [Linux-fbdev-devel] [PATCH] neofb patches

Re: [Linux-fbdev-devel] [PATCH] neofb patches

[James Simmons]

> Ok, I've got everything except the blanking patch (which isn't finished
> anyway) converted to apply cleanly to James' patched driver source. 
> Everything works fine on my laptop as far as I can tell.  Additional
> feedback is welcome.
> 
> I've put up a web page for the patches.  They can be found at
> http://www.foogod.com/~alex/neofb/

Got it. I merged your patches. I also did a few fixes. The code had issues 
with non byte align images, i.e sparc 12x22 fonts. Now it works. I posted 
at

http://phoenix.infradead.org:~/jsimmons/neofb.diff.gz

This is against the latest kernel.

Re: [Linux-fbdev-devel] [PATCH] neofb patches

[Randy.Dunlap]

On Sat, 24 Apr 2004 00:00:23 +0100 (BST) James Simmons <jsimmons@infradead.org> wrote:

| 
| > Ok, I've got everything except the blanking patch (which isn't finished
| > anyway) converted to apply cleanly to James' patched driver source. 
| > Everything works fine on my laptop as far as I can tell.  Additional
| > feedback is welcome.
| > 
| > I've put up a web page for the patches.  They can be found at
| > http://www.foogod.com/~alex/neofb/
| 
| Got it. I merged your patches. I also did a few fixes. The code had issues 
| with non byte align images, i.e sparc 12x22 fonts. Now it works. I posted 
| at
| 
| http://phoenix.infradead.org:~/jsimmons/neofb.diff.gz
| 
| This is against the latest kernel.

Hi James,

I think it would help a bit if someone could load
http://phoenix.infradead.org/~jsimmons/ in a web browser
and be able to see a list of files/patches/etc there
instead of having to know an exact file name to grab.

--
~Randy

Re: [Linux-fbdev-devel] [PATCH] neofb patches

[Alex Stewart]

> | http://phoenix.infradead.org:~/jsimmons/neofb.diff.gz
> |
> | This is against the latest kernel.
>
> Hi James,
>
> I think it would help a bit if someone could load
> http://phoenix.infradead.org/~jsimmons/ in a web browser
> and be able to see a list of files/patches/etc there
> instead of having to know an exact file name to grab.

Well, since he only seems to have one patch available at any given time,
this doesn't seem like that big a deal to me, personally..  I was,
however, thinking of suggesting that it might be easier to keep track of
things if there were some sort of version numbers or datestamps or
something in the filename so somebody can tell that this "neofb.diff.gz"
is actually a different patch from the "neofb.diff.gz" that was in exactly
the same place yesterday..

-alex

Re: [Linux-fbdev-devel] [PATCH] neofb patches

[James Simmons]

> Well, since he only seems to have one patch available at any given time,
> this doesn't seem like that big a deal to me, personally..  I was,
> however, thinking of suggesting that it might be easier to keep track of
> things if there were some sort of version numbers or datestamps or
> something in the filename so somebody can tell that this "neofb.diff.gz"
> is actually a different patch from the "neofb.diff.gz" that was in exactly
> the same place yesterday..

Okay. I can add a date stamp on it.

Re: [Linux-fbdev-devel] [PATCH] neofb patches

[James Simmons]

> Hi James,
> 
> I think it would help a bit if someone could load
> http://phoenix.infradead.org/~jsimmons/ in a web browser
> and be able to see a list of files/patches/etc there
> instead of having to know an exact file name to grab.

Your right. I have to wipe up a web page for that.

Re: [Linux-fbdev-devel] [PATCH] neofb patches

[Alex Stewart]

> Got it. I merged your patches.

Umm, I would really appreciate it if you didn't silently leave out bits of
my patches and then just say "I merged your patches".  It took me a little
bit to figure out that the reason panning now isn't used for fbconsole
scrolls is because you just didn't bother to put that part of my patch in.

Is there some reason you left out the following piece of my modedb patch?

+       /* Turn on panning for console scroll by default */
+       info->var.yres_virtual = 30000;
+       info->var.accel_flags |= FB_ACCELF_TEXT;
+       if (neofb_check_var(&info->var, info))
+               goto err_map_video;

-alex

Re: [Linux-fbdev-devel] [PATCH] neofb patches

[James Simmons]

> Umm, I would really appreciate it if you didn't silently leave out bits of
> my patches and then just say "I merged your patches".  It took me a little
> bit to figure out that the reason panning now isn't used for fbconsole
> scrolls is because you just didn't bother to put that part of my patch in.
> 
> Is there some reason you left out the following piece of my modedb patch?
> 
> +       /* Turn on panning for console scroll by default */
> +       info->var.yres_virtual = 30000;
> +       info->var.accel_flags |= FB_ACCELF_TEXT;
> +       if (neofb_check_var(&info->var, info))
> +               goto err_map_video;

   The reason is because fb_find_mode calls check_var for us. No reason to 
call it twice. The large yres_virtual being 30000 that is not needed any 
longer. The accel flag is set in neofb_check_var. The current test is

if (var->bits_per_pixel >= 24 || !par->neo2200)
	var->accel_flags &= ~FB_ACCEL_TEXT;

Should we drop the bpp >= 24 test? Do you observe this problem at all 
depths.