[PATCH] support I2C_M_NO_RD_ACK in i2c-algo-bit

[PATCH] support I2C_M_NO_RD_ACK in i2c-algo-bit

[Kevin O'Connor]

This is a message resend - the original didn't make it to lkml.

Hi Greg,

I have an I2C device (Samsung ks0127 video grabber) with a peculiar i2c
implementation.  When reading bytes, it only senses for the stop condition
in the place where the acknowledge bit should be.  So, to properly support
this device acks need to be turned off during reads.

There is an I2C_M_NO_RD_ACK bit already defined in i2c.h which appears to
be what I want.  Unfortunately it doesn't seem to be used anywhere in the
current tree.  At the end of this message is a patch to teach i2c_algo_bit
to honor the bit.

-Kevin


--- gold-2.6/drivers/i2c/algos/i2c-algo-bit.c	2004-04-04 13:56:03.000000000 -0400
+++ linux-2.6.5/drivers/i2c/algos/i2c-algo-bit.c	2004-04-20 00:35:39.103934872 -0400
@@ -381,7 +381,13 @@
 			break;
 		}
 
-		if ( count > 1 ) {		/* send ack */
+		temp++;
+		count--;
+
+		if (msg->flags & I2C_M_NO_RD_ACK)
+			continue;
+
+		if ( count > 0 ) {		/* send ack */
 			sdalo(adap);
 			DEBPROTO(printk(" Am "));
 		} else {
@@ -395,8 +401,6 @@
 		};
 		scllo(adap);
 		sdahi(adap);
-		temp++;
-		count--;
 	}
 	return rdcount;
 }

Re: [PATCH] support I2C_M_NO_RD_ACK in i2c-algo-bit

[Greg KH]

On Sun, Apr 25, 2004 at 02:06:45PM -0400, Kevin O'Connor wrote:
> This is a message resend - the original didn't make it to lkml.
> 
> Hi Greg,
> 
> I have an I2C device (Samsung ks0127 video grabber) with a peculiar i2c
> implementation.  When reading bytes, it only senses for the stop condition
> in the place where the acknowledge bit should be.  So, to properly support
> this device acks need to be turned off during reads.
> 
> There is an I2C_M_NO_RD_ACK bit already defined in i2c.h which appears to
> be what I want.  Unfortunately it doesn't seem to be used anywhere in the
> current tree.  At the end of this message is a patch to teach i2c_algo_bit
> to honor the bit.

Applied, thanks.

greg k-h